From: Evgeniy Polyakov <zbr@ioremap.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Devendra Naga <devendra.aaru@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/w1: free the w1_master at w1_free_dev and return a correct return value
Date: Thu, 21 Jun 2012 11:48:03 +0400 [thread overview]
Message-ID: <20120621074803.GA9980@ioremap.net> (raw)
In-Reply-To: <20120620235503.GA31520@kroah.com>
On Wed, Jun 20, 2012 at 04:55:03PM -0700, Greg Kroah-Hartman (gregkh@linuxfoundation.org) wrote:
> No, this is wrong, the memory will be freed in w1_master_release(),
> right? It is not freed here, sorry, this patch is incorrect.
Yes, you are right.
It is exactly that ->release() callback I missed!
--
Evgeniy Polyakov
prev parent reply other threads:[~2012-06-21 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 16:17 [PATCH] drivers/w1: free the w1_master at w1_free_dev and return a correct return value Devendra Naga
2012-06-20 8:06 ` Evgeniy Polyakov
2012-06-20 12:57 ` devendra.aaru
2012-06-20 23:55 ` Greg Kroah-Hartman
2012-06-21 4:44 ` devendra.aaru
2012-06-21 14:39 ` Greg Kroah-Hartman
2012-06-23 18:26 ` devendra.aaru
2012-06-21 7:48 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621074803.GA9980@ioremap.net \
--to=zbr@ioremap.net \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox