public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Roland Stigge <stigge@antcom.de>
Cc: dgdunix@gmail.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: gpio_keys_polled.c and DT
Date: Thu, 21 Jun 2012 01:53:40 -0700	[thread overview]
Message-ID: <20120621085340.GE2193@core.coreip.homeip.net> (raw)
In-Reply-To: <4FE0946B.8030201@antcom.de>

Hi Roland,

On Tue, Jun 19, 2012 at 05:02:03PM +0200, Roland Stigge wrote:
> Hi,
> 
> as far as I can see, gpio_keys_polled.c currently doesn't support DT
> initialization. Is there a plan in this regard?
> 
> Rather than duplicating the respective code from gpio_keys.c, maybe
> gpio_keys.c could be changed to support a polled mode also? This way,
> gpio_keys_polled.c could be removed.

We had several attempts at gpio_keys and adding a polled mode and we
ended up with the driver getting too complex and having unwanted
dependencies. At the moment I believe that the split between gpio_keys.c
and gpio_keys_polled.c is justified even it it may lead to certain code
duplication.

However, if DT bindings are really the same we could split them off into
a separate library module used by both drivers.

Thanks.

-- 
Dmitry

      reply	other threads:[~2012-06-21  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 15:02 gpio_keys_polled.c and DT Roland Stigge
2012-06-21  8:53 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621085340.GE2193@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=dgdunix@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stigge@antcom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox