* [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
@ 2012-06-21 13:32 Uros Vampl
2012-06-21 14:29 ` Don Zickus
0 siblings, 1 reply; 6+ messages in thread
From: Uros Vampl @ 2012-06-21 13:32 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Don Zickus,
Peter Zijlstra, Peter Chubb, linux-kernel, stable
Add a quirk to make the Acer Aspire One Happy2 reboot properly. For
reference, discussion at the Arch forums:
https://bbs.archlinux.org/viewtopic.php?id=143716
Signed-off-by: Uroš Vampl <mobile.leecher@gmail.com>
--- linux-3.4.3.orig/arch/x86/kernel/reboot.c 2012-06-17 20:21:44.000000000 +0200
+++ linux-3.4.3/arch/x86/kernel/reboot.c 2012-06-21 15:16:15.003430778 +0200
@@ -317,6 +317,14 @@
DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
},
},
+ { /* Handle reboot issue on Acer Aspire One Happy2 */
+ .callback = set_kbd_reboot,
+ .ident = "Acer Aspire One Happy2",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
+ },
+ },
{ }
};
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
2012-06-21 13:32 [PATCH] x86: Aspire One Happy2 reboots only with the kbd method Uros Vampl
@ 2012-06-21 14:29 ` Don Zickus
2012-06-21 14:40 ` H. Peter Anvin
0 siblings, 1 reply; 6+ messages in thread
From: Don Zickus @ 2012-06-21 14:29 UTC (permalink / raw)
To: Uros Vampl
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Peter Zijlstra,
Peter Chubb, linux-kernel, stable
On Thu, Jun 21, 2012 at 03:32:03PM +0200, Uros Vampl wrote:
> Add a quirk to make the Acer Aspire One Happy2 reboot properly. For
> reference, discussion at the Arch forums:
> https://bbs.archlinux.org/viewtopic.php?id=143716
>
> Signed-off-by: Uroš Vampl <mobile.leecher@gmail.com>
Seems fine by me based on the thread above. Not sure if there is another
callback that should be tried first before using BOOT_KBD. Probably
doesn't matter.
Acked-by: Don Zickus <dzickus@redhat.com>
>
> --- linux-3.4.3.orig/arch/x86/kernel/reboot.c 2012-06-17 20:21:44.000000000 +0200
> +++ linux-3.4.3/arch/x86/kernel/reboot.c 2012-06-21 15:16:15.003430778 +0200
> @@ -317,6 +317,14 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
> },
> },
> + { /* Handle reboot issue on Acer Aspire One Happy2 */
> + .callback = set_kbd_reboot,
> + .ident = "Acer Aspire One Happy2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
> + },
> + },
> { }
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
2012-06-21 14:29 ` Don Zickus
@ 2012-06-21 14:40 ` H. Peter Anvin
2012-06-21 22:22 ` Uros Vampl
0 siblings, 1 reply; 6+ messages in thread
From: H. Peter Anvin @ 2012-06-21 14:40 UTC (permalink / raw)
To: Don Zickus
Cc: Uros Vampl, Thomas Gleixner, Ingo Molnar, x86, Peter Zijlstra,
Peter Chubb, linux-kernel, stable
On 06/21/2012 07:29 AM, Don Zickus wrote:
> On Thu, Jun 21, 2012 at 03:32:03PM +0200, Uros Vampl wrote:
>> Add a quirk to make the Acer Aspire One Happy2 reboot properly. For
>> reference, discussion at the Arch forums:
>> https://bbs.archlinux.org/viewtopic.php?id=143716
>>
>> Signed-off-by: Uroš Vampl <mobile.leecher@gmail.com>
>
> Seems fine by me based on the thread above. Not sure if there is another
> callback that should be tried first before using BOOT_KBD. Probably
> doesn't matter.
>
Actually please do the following:
a) please use "acpidump" (from the pmtools package) to dump the ACPI
tables, specifically the FACP table;
b) please figure out which of reboot=pci, reboot=kbd, reboot=bios, and
reboot=triple work on this platform.
-hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
2012-06-21 14:40 ` H. Peter Anvin
@ 2012-06-21 22:22 ` Uros Vampl
2012-06-21 22:27 ` H. Peter Anvin
0 siblings, 1 reply; 6+ messages in thread
From: Uros Vampl @ 2012-06-21 22:22 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Don Zickus, Thomas Gleixner, Ingo Molnar, x86, Peter Zijlstra,
Peter Chubb, linux-kernel
On 21.06.12 07:40, H. Peter Anvin wrote:
> On 06/21/2012 07:29 AM, Don Zickus wrote:
> > On Thu, Jun 21, 2012 at 03:32:03PM +0200, Uros Vampl wrote:
> >> Add a quirk to make the Acer Aspire One Happy2 reboot properly. For
> >> reference, discussion at the Arch forums:
> >> https://bbs.archlinux.org/viewtopic.php?id=143716
> >>
> >> Signed-off-by: Uroš Vampl <mobile.leecher@gmail.com>
> >
> > Seems fine by me based on the thread above. Not sure if there is another
> > callback that should be tried first before using BOOT_KBD. Probably
> > doesn't matter.
> >
>
> Actually please do the following:
>
> a) please use "acpidump" (from the pmtools package) to dump the ACPI
> tables, specifically the FACP table;
> b) please figure out which of reboot=pci, reboot=kbd, reboot=bios, and
> reboot=triple work on this platform.
>
> -hpa
>
I advised the Arch user to join this discussion and provide the
requested info. I immediately went for kbd as the solution because
that's exactly what I need for my own Aspire One - that AOA110 quirk
that's visible in the context of this patch. I figured it's a pattern,
Aspire One machines quirky in the same way.
Regards,
Uroš
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
2012-06-21 22:22 ` Uros Vampl
@ 2012-06-21 22:27 ` H. Peter Anvin
2013-01-01 13:16 ` Elisey Shemyakin
0 siblings, 1 reply; 6+ messages in thread
From: H. Peter Anvin @ 2012-06-21 22:27 UTC (permalink / raw)
To: Uros Vampl
Cc: Don Zickus, Thomas Gleixner, Ingo Molnar, x86, Peter Zijlstra,
Peter Chubb, linux-kernel
On 06/21/2012 03:22 PM, Uros Vampl wrote:
>
> I advised the Arch user to join this discussion and provide the
> requested info. I immediately went for kbd as the solution because
> that's exactly what I need for my own Aspire One - that AOA110 quirk
> that's visible in the context of this patch. I figured it's a pattern,
> Aspire One machines quirky in the same way.
>
Probably, but we'd like to figure out what is going on.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method
2012-06-21 22:27 ` H. Peter Anvin
@ 2013-01-01 13:16 ` Elisey Shemyakin
0 siblings, 0 replies; 6+ messages in thread
From: Elisey Shemyakin @ 2013-01-01 13:16 UTC (permalink / raw)
To: linux-kernel
H. Peter Anvin <hpa <at> zytor.com> writes:
>
> On 06/21/2012 03:22 PM, Uros Vampl wrote:
> >
> > I advised the Arch user to join this discussion and provide the
> > requested info. I immediately went for kbd as the solution because
> > that's exactly what I need for my own Aspire One - that AOA110 quirk
> > that's visible in the context of this patch. I figured it's a pattern,
> > Aspire One machines quirky in the same way.
> >
>
> Probably, but we'd like to figure out what is going on.
>
> -hpa
>
Hi. I got here from this forum https://bbs.archlinux.org/viewtopic.php?id=143716
with the same issue on the same device.
Here is FACP table from acpidump output:
FACP @ 0x7f5fd000
0000: 46 41 43 50 f4 00 00 00 04 4c 41 43 52 53 59 53 FACP.....LACRSYS
0010: 41 43 52 50 52 44 43 54 01 00 00 00 31 30 32 35 ACRPRDCT....1025
0020: 00 00 04 00 00 30 58 7f 00 10 5f 7f 00 02 09 00 .....0X..._.....
0030: b2 00 00 00 a0 a1 00 80 00 04 00 00 00 00 00 00 ................
0040: 04 04 00 00 00 00 00 00 20 04 00 00 08 04 00 00 ........ .......
0050: 28 04 00 00 00 00 00 00 04 02 01 04 08 00 00 85 (...............
0060: 65 00 e9 03 00 00 00 00 01 03 0d 00 00 03 00 00 e...............
0070: a5 84 00 00 01 08 00 01 b2 00 00 00 00 00 00 00 ................
0080: fb 00 00 00 00 30 58 7f 00 00 00 00 00 10 5f 7f .....0X......._.
0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00f0: 00 00 00 00
I have tried to reboot with different kernel parameters.
Worked: kbd, efi, bios
Not worked: acpi, triple, pci
So, this patch works for me:
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -447,6 +447,14 @@
DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
},
},
+ { /* Handle reboot issue on the Acer Aspire One Happy2. */
+ .callback = set_kbd_reboot,
+ .ident = "Acer Aspire One Happy2",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
+ },
+ },
{ }
};
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-01 13:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 13:32 [PATCH] x86: Aspire One Happy2 reboots only with the kbd method Uros Vampl
2012-06-21 14:29 ` Don Zickus
2012-06-21 14:40 ` H. Peter Anvin
2012-06-21 22:22 ` Uros Vampl
2012-06-21 22:27 ` H. Peter Anvin
2013-01-01 13:16 ` Elisey Shemyakin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox