From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757178Ab2FUOaV (ORCPT ); Thu, 21 Jun 2012 10:30:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754369Ab2FUOaU (ORCPT ); Thu, 21 Jun 2012 10:30:20 -0400 Date: Thu, 21 Jun 2012 10:29:38 -0400 From: Don Zickus To: Uros Vampl Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Peter Chubb , linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] x86: Aspire One Happy2 reboots only with the kbd method Message-ID: <20120621142938.GZ32472@redhat.com> References: <20120621133203.GA26316@zverina> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120621133203.GA26316@zverina> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2012 at 03:32:03PM +0200, Uros Vampl wrote: > Add a quirk to make the Acer Aspire One Happy2 reboot properly. For > reference, discussion at the Arch forums: > https://bbs.archlinux.org/viewtopic.php?id=143716 > > Signed-off-by: Uroš Vampl Seems fine by me based on the thread above. Not sure if there is another callback that should be tried first before using BOOT_KBD. Probably doesn't matter. Acked-by: Don Zickus > > --- linux-3.4.3.orig/arch/x86/kernel/reboot.c 2012-06-17 20:21:44.000000000 +0200 > +++ linux-3.4.3/arch/x86/kernel/reboot.c 2012-06-21 15:16:15.003430778 +0200 > @@ -317,6 +317,14 @@ > DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"), > }, > }, > + { /* Handle reboot issue on Acer Aspire One Happy2 */ > + .callback = set_kbd_reboot, > + .ident = "Acer Aspire One Happy2", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), > + DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"), > + }, > + }, > { } > }; >