linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Rakesh Iyer <rni@google.com>
Cc: Tejun Heo <tj@kernel.org>, Josh Hunt <joshhunt00@gmail.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, Chad Talbott <ctalbott@google.com>
Subject: Re: multi-second application stall in open()
Date: Fri, 22 Jun 2012 10:15:57 -0400	[thread overview]
Message-ID: <20120622141556.GC18409@redhat.com> (raw)
In-Reply-To: <CAOT6A4-a49wLHcQepUxJCDxOxfnSTEWa72OweLsmrea85OyrCg@mail.gmail.com>

On Thu, Jun 21, 2012 at 02:45:56PM -0700, Rakesh Iyer wrote:
> Hello,
> 
> I coded up the watchdog and dropped it in but never did get the time to go
> looking for evidence of stalls so no confirmed evidence of what the cause
> was.
> 
> Chad and I did manage to stare at the code long and hard and sort of
> convince ourselves that cfq_cfqq_wait_busy & associated logic could be the
> cause of the stall (strictly in my opinion - that logic can be fully be
> fully folded into the idling logic, but that's a discussion for another
> day).

Rakesh, so in your watchdog code you just kicked the queue? I am wondering
how does that help. In the sense, that we did do cfq_schedule_dispatch
here which will run the queue and CFQ did not find any pending requests to dispatch. So even if we kick the queue later, CFQ will not find any requests to
dispatch until and unless something changes in the mean time.

So I am not sure if it is same issue as you were facing.

Thanks
Vivek

  parent reply	other threads:[~2012-06-22 14:16 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 21:56 multi-second application stall in open() Josh Hunt
2012-03-07 13:43 ` Josh Hunt
2012-03-07 16:28   ` Vivek Goyal
2012-03-07 18:56     ` Jens Axboe
2012-03-07 19:56       ` Vivek Goyal
2012-03-07 21:08       ` Josh Hunt
2012-03-08 22:22         ` Josh Hunt
2012-03-08 23:40           ` Vivek Goyal
     [not found]             ` <CAKA=qzbsL9UVYLZ3=hoT-1jfp=v=_Sr=h+YeHu0qAA=Ko_7P6w@mail.gmail.com>
2012-06-21 19:26               ` Josh Hunt
2012-06-21 20:32                 ` Vivek Goyal
2012-06-21 20:36                   ` Tejun Heo
2012-06-21 21:28                     ` Josh Hunt
2012-06-21 21:32                       ` Tejun Heo
2012-06-21 21:48                         ` Rakesh Iyer
     [not found]                         ` <CAOT6A4-a49wLHcQepUxJCDxOxfnSTEWa72OweLsmrea85OyrCg@mail.gmail.com>
2012-06-22 14:15                           ` Vivek Goyal [this message]
2012-06-21 21:11                   ` Josh Hunt
2012-06-22 14:12                     ` Vivek Goyal
2012-06-22 20:05                       ` Josh Hunt
2012-06-22 20:22                         ` Josh Hunt
2012-06-22 20:42                           ` Vivek Goyal
2012-06-22 20:53                             ` Josh Hunt
2012-06-22 20:57                               ` Josh Hunt
2012-06-22 21:34                                 ` Josh Hunt
2012-06-25 13:30                                   ` Vivek Goyal
2012-06-25 16:22                                     ` Josh Hunt
2012-06-25 21:18                                       ` Vivek Goyal
2012-06-25 23:05                                         ` Josh Hunt
2012-06-26  4:01                                           ` Josh Hunt
2012-06-26 12:59                                             ` Vivek Goyal
2012-06-26 15:18                                               ` Josh Hunt
2012-06-26 15:53                                                 ` Vivek Goyal
2012-06-26 20:37                                                   ` Josh Hunt
2012-06-26 20:56                                                     ` Tejun Heo
     [not found]                                                       ` <CAKA=qzbBtteDjHiPogCvN5jOSiPrDxx=vn96p02bXUy=6=jAgA@mail.gmail.com>
2012-06-26 23:44                                                         ` Josh Hunt
2012-06-27 17:21                                                           ` Josh Hunt
2012-06-27 17:38                                                             ` Tejun Heo
2012-06-27 17:44                                                               ` Josh Hunt
2012-06-27 17:54                                                                 ` Tejun Heo
2012-06-27 17:59                                                                   ` Josh Hunt
2012-06-29 23:02                                                                     ` Tejun Heo
2012-06-30  0:37                                                                       ` Josh Hunt
2012-07-04  1:12                                                                         ` Tejun Heo
2012-07-18 17:48                                                                           ` Tejun Heo
2012-06-26 20:43                                                 ` Tejun Heo
2012-06-25 17:26                                     ` Tejun Heo
2012-03-07 19:47     ` Josh Hunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120622141556.GC18409@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=ctalbott@google.com \
    --cc=joshhunt00@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rni@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).