From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Rob Landley <rob@landley.net>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Doug Ledford <dledford@redhat.com>,
Marcel Holtmann <marcel@holtmann.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Joe Korty <joe.korty@ccur.com>,
David Howells <dhowells@redhat.com>,
James Morris <james.l.morris@oracle.com>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3] fs: introduce pipe-only dump mode suid_dumpable=3
Date: Fri, 22 Jun 2012 15:20:29 -0700 [thread overview]
Message-ID: <20120622152029.638ade70.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jLOJrZTNKh=G75wP2fo-cPj_mM-Urc+4hDVvyJpiy+7Dg@mail.gmail.com>
On Fri, 22 Jun 2012 15:07:45 -0700
Kees Cook <keescook@chromium.org> wrote:
> mode=2 to disk _should_ break, is my point.
And my point is that we should at least tell people that we broke it.
I don't believe that returning an EINVAL from the write() is
sufficient. Because it introduces a high risk that people will run
misconfigured systems for lengthy periods and it will cause them to
have to do a *lot* of work once they discover that their system is
misbehaving.
So if we really really must instabreak back-compatibility, we should
shout loudly into syslog about it: tell people that their system is
broken and tell them what to do about it.
And we should explain and justify this extraordinary action in the
patch changelog.
next prev parent reply other threads:[~2012-06-22 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 19:24 [PATCH v3] fs: introduce pipe-only dump mode suid_dumpable=3 Kees Cook
2012-06-22 19:55 ` Andrew Morton
2012-06-22 21:09 ` Kees Cook
2012-06-22 21:34 ` Andrew Morton
2012-06-22 21:51 ` Kees Cook
2012-06-22 21:57 ` Andrew Morton
2012-06-22 22:07 ` Kees Cook
2012-06-22 22:20 ` Andrew Morton [this message]
2012-06-22 22:26 ` Kees Cook
2012-06-23 7:30 ` James Morris
2012-06-23 22:34 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622152029.638ade70.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=dledford@redhat.com \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=joe.korty@ccur.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rob@landley.net \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox