Re: [PATCH 01/12] f81232: correct stubbed termios handler

Greg KH
2012-06-27T02:22:36Z

On Fri, Jun 22, 2012 at 04:36:42PM +0100, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/usb/serial/f81232.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 499b15f..acd3267 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -177,6 +177,7 @@ static void f81232_set_termios(struct tty_struct *tty,
> return;
>
> /* Do the real work here... */
> + tty_termios_copy_hw(&tty->termios, old_termios);
> }

This patch breaks the build:

drivers/usb/serial/f81232.c: In function ‘f81232_set_termios’:
drivers/usb/serial/f81232.c:180:2: warning: passing argument 1 of ‘tty_termios_copy_hw’ from incompatible pointer type [enabled by default]
include/linux/tty.h:454:13: note: expected ‘struct ktermios *’ but argument is of type ‘struct ktermios **’

I know the driver isn't complete, but it should at least build :)

thanks,

greg k-h