From: Andrew Morton <akpm@linux-foundation.org>
To: shuox.liu@intel.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
"Zhang, Yanmin" <yanmin.zhang@intel.com>,
"Andrew J. Schorr" <aschorr@telemetry-investments.com>,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpuidle: move field disable from per-driver to per-cpu
Date: Fri, 22 Jun 2012 16:10:30 -0700 [thread overview]
Message-ID: <20120622161030.da016ccf.akpm@linux-foundation.org> (raw)
In-Reply-To: <4FD95200.1090701@intel.com>
On Thu, 14 Jun 2012 10:52:48 +0800
ShuoX Liu <shuox.liu@intel.com> wrote:
> From: ShuoX Liu <shuox.liu@intel.com>
>
> Andrew J.Schorr raises a question. When he changes the disable setting
> on a single CPU, it affects all the other CPUs. Basically, currently,
> the disable field is per-driver instead of per-cpu. All the C states of
> the same driver are shared by all CPU in the same machine.
>
> Below patch changes field disable to per-cpu, so we could set this
> separately for each cpu.
>
> ...
>
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -34,6 +34,7 @@ struct cpuidle_driver;
> struct cpuidle_state_usage {
> void *driver_data;
>
> + unsigned long long disable;
hrmpf. We're using 64 bits for this where one bit would do, afaict
because the magic macros in drivers/cpuidle/sysfs.c are using %llu.
next prev parent reply other threads:[~2012-06-22 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 2:52 [PATCH] cpuidle: move field disable from per-driver to per-cpu ShuoX Liu
2012-06-14 14:41 ` Andrew J. Schorr
2012-06-15 12:08 ` Deepthi Dharwar
2012-06-18 6:42 ` Yanmin Zhang
2012-06-22 23:10 ` Andrew Morton [this message]
2012-06-24 9:46 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622161030.da016ccf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aschorr@telemetry-investments.com \
--cc=deepthi@linux.vnet.ibm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuox.liu@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox