From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749Ab2FWAUo (ORCPT ); Fri, 22 Jun 2012 20:20:44 -0400 Received: from mail.us.es ([193.147.175.20]:51193 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756380Ab2FWAUn (ORCPT ); Fri, 22 Jun 2012 20:20:43 -0400 Date: Sat, 23 Jun 2012 02:20:35 +0200 From: Pablo Neira Ayuso To: valdis.kletnieks@vt.edu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: next-20120620 build error in netfilter Message-ID: <20120623002035.GB21360@1984> References: <32596.1340212473@turing-police.cc.vt.edu> <20120620172801.GA9385@1984> <55558.1340217472@turing-police.cc.vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55558.1340217472@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2012 at 02:37:52PM -0400, valdis.kletnieks@vt.edu wrote: > On Wed, 20 Jun 2012 19:28:01 +0200, Pablo Neira Ayuso said: > > On Wed, Jun 20, 2012 at 01:14:33PM -0400, Valdis Kletnieks wrote: > > > Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m > > > > > > LD init/built-in.o > > > net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust' > > > make: *** [vmlinux] Error 1 > > > > I guess you have NF_CT_NETLINK=y, right? > > Yes. > > Temporary workaround was setting NF_NAT=n (I don't use NAT, I just usually > build all the netfilter modules as =m even if I don't use them, just to provide > build coverage and trip over stuff like this). Probably NF_CT_NETLINK=m is a better workaround. Anyway, I've enqueued the following patch to fix this: http://1984.lsi.us.es/git/nf-next/commit/?id=d584a61a931e6cbfef0dd811c4ae0250ec5987f4 So you can use your previous config. Thanks.