From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fengguang Wu <wfg@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [net-next:master 49/50] net/netfilter/nfnetlink_queue_ct.c:23:18: sparse: incompatible types in comparison expression (different address spaces)
Date: Sat, 23 Jun 2012 02:41:03 +0200 [thread overview]
Message-ID: <20120623004103.GA21550@1984> (raw)
In-Reply-To: <20120619114113.GA19526@localhost>
On Tue, Jun 19, 2012 at 02:00:50PM +0800, wfg@linux.intel.com wrote:
> Hi Pablo,
>
> There are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head: 6bdc5f49e365a5403b9fdef01ceb37241ab00f9b
> commit: 7c62234547255ce4c385a218915965bc2f14fe45 [49/50] netfilter: nfnetlink_queue: fix compilation with NF_CONNTRACK disabled
>
> All sparse warnings:
>
> net/netfilter/nfnetlink_queue_ct.c:23:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:45:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:63:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nfnetlink_queue_ct.c:91:18: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1100:27: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1222:34: sparse: incompatible types in comparison expression (different address spaces)
> net/netfilter/nf_conntrack_netlink.c:1222:34: sparse: incompatible types in comparison expression (different address spaces)
>
> net/netfilter/nfnetlink_queue_ct.c:23:
> 20 struct nf_conn *ct;
> 21
> 22 /* rcu_read_lock()ed by __nf_queue already. */
> > 23 nfq_ct = rcu_dereference(nfq_ct_hook);
> 24 if (nfq_ct == NULL)
> 25 return NULL;
> 26
JFYI: I've enqueued the following patch to fix this sparse warning:
http://1984.lsi.us.es/git/nf-next/commit/?id=5a05fae5ca7cd5279567747fc34d60413b504cd6
prev parent reply other threads:[~2012-06-23 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120619060050.GA14867@localhost>
[not found] ` <20120619112823.GB445@1984>
2012-06-19 11:41 ` [net-next:master 49/50] net/netfilter/nfnetlink_queue_ct.c:23:18: sparse: incompatible types in comparison expression (different address spaces) Fengguang Wu
2012-06-19 11:56 ` Pablo Neira Ayuso
2012-06-19 12:35 ` Eric Dumazet
2012-06-23 0:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623004103.GA21550@1984 \
--to=pablo@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox