* [PATCH] Staging: android: logger.c: fixed some printk macros
@ 2012-06-22 5:44 Sherwin Soltani
2012-06-23 4:03 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Sherwin Soltani @ 2012-06-22 5:44 UTC (permalink / raw)
To: greg; +Cc: swetland, devel, linux-kernel, Sherwin Soltani
Changed a few printk messages in logger.c to make checkpatch.pl happy.
Signed-off-by: Sherwin Soltani <sherwin@wybc.com>
---
drivers/staging/android/logger.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index b2e71c6..b490c5c 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -621,13 +621,13 @@ static int __init create_log(char *log_name, int size)
/* finally, initialize the misc device for this log */
ret = misc_register(&log->misc);
if (unlikely(ret)) {
- printk(KERN_ERR "logger: failed to register misc "
- "device for log '%s'!\n", log->misc.name);
+ pr_err("logger: failed to register misc device for log '%s'!\n",
+ log->misc.name);
goto out_free_log;
}
- printk(KERN_INFO "logger: created %luK log '%s'\n",
- (unsigned long) log->size >> 10, log->misc.name);
+ pr_info("logger: created %luK log '%s'\n",
+ (unsigned long) log->size >> 10, log->misc.name);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: android: logger.c: fixed some printk macros
2012-06-22 5:44 [PATCH] Staging: android: logger.c: fixed some printk macros Sherwin Soltani
@ 2012-06-23 4:03 ` Greg KH
2012-06-23 5:43 ` Sherwin Soltani
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2012-06-23 4:03 UTC (permalink / raw)
To: Sherwin Soltani; +Cc: swetland, devel, linux-kernel
On Fri, Jun 22, 2012 at 01:44:46AM -0400, Sherwin Soltani wrote:
> Changed a few printk messages in logger.c to make checkpatch.pl happy.
>
> Signed-off-by: Sherwin Soltani <sherwin@wybc.com>
> ---
> drivers/staging/android/logger.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
This patch does not apply, did you make it against Linus's tree or
linux-next? You need to always work off of linux-next please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: android: logger.c: fixed some printk macros
2012-06-23 4:03 ` Greg KH
@ 2012-06-23 5:43 ` Sherwin Soltani
0 siblings, 0 replies; 3+ messages in thread
From: Sherwin Soltani @ 2012-06-23 5:43 UTC (permalink / raw)
To: Greg KH; +Cc: swetland, devel, linux-kernel
On 06/23/2012 12:03 AM, Greg KH wrote:
> This patch does not apply, did you make it against Linus's tree or
> linux-next? You need to always work off of linux-next please.
>
> thanks,
>
> greg k-h
Sorry, my mistake. I'll rewrite the patch working off of linux-next and
resubmit.
Sherwin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-23 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-22 5:44 [PATCH] Staging: android: logger.c: fixed some printk macros Sherwin Soltani
2012-06-23 4:03 ` Greg KH
2012-06-23 5:43 ` Sherwin Soltani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox