From: "John W. Linville" <linville@tuxdriver.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2012-06-22
Date: Sat, 23 Jun 2012 00:11:03 -0400 [thread overview]
Message-ID: <20120623041103.GA29801@tuxdriver.com> (raw)
In-Reply-To: <20453.9687.225096.194368@gargle.gargle.HOWL>
On Sat, Jun 23, 2012 at 07:41:35AM +0530, Sujith Manoharan wrote:
> David Miller wrote:
> > From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> > Date: Sat, 23 Jun 2012 05:05:10 +0530
> >
> > > Sujith Manoharan wrote:
> > >> John W. Linville wrote:
> > >> > Mohammed Shafi Shajakhan (1):
> > >> > ath9k_hw: avoid possible infinite loop in ar9003_get_pll_sqsum_dvc
> > >>
> > >> Um, this commit doesn't really fix anything - the timeout is also
> > >> arbitrary. Can you remove this from the 3.5 queue ? Thanks.
> > >
> > > A review of the patch later, I think it's good. At least there's a
> > > WARN_ON_ONCE() to indicate the situation in which the measurement fails.
> > > It might come in handy as a debugging aid.
> >
> > Thanks for wasting our time.
> >
> > Make these determinations when changes to into John's tree, not
> > later when he asks me to pull them into mine.
>
> The patch was under review:
> http://marc.info/?l=linux-wireless&m=134001371002288&w=2
Quibbling over the exact number of iterations for a timeout didn't
seem is important as avoiding an endless loop...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-06-23 4:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 20:17 pull request: wireless 2012-06-22 John W. Linville
2012-06-22 23:09 ` David Miller
2012-06-22 23:16 ` Sujith Manoharan
2012-06-22 23:35 ` Sujith Manoharan
2012-06-22 23:56 ` David Miller
2012-06-23 2:11 ` Sujith Manoharan
2012-06-23 4:11 ` John W. Linville [this message]
2012-06-23 6:10 ` Sujith Manoharan
2012-06-23 10:45 ` Mohammed Shafi
2012-06-22 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623041103.GA29801@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=c_manoha@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox