From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-mm-cc@laptop.org, linux-kernel@vger.kernel.org,
ngupta@vflare.org
Subject: Re: [PATCH 2/2] staging: zram: Remove useless struct zobj_header
Date: Sat, 23 Jun 2012 18:18:19 +0300 [thread overview]
Message-ID: <20120623151819.GE5333@mwanda> (raw)
In-Reply-To: <1340249565-29404-3-git-send-email-marcos.souza.org@gmail.com>
On Thu, Jun 21, 2012 at 12:32:45AM -0300, Marcos Paulo de Souza wrote:
> The struct zobj_header has no members, so the sizeof(struct zobj_header *)
> always returns zero. For this reason we are removing this useless struct.
>
I've been out for the past few days and I'm slowly catching up. If
you want you could update this comment as well:
drivers/staging/zram/zram_drv.h
40 /*
41 * NOTE: max_zpage_size must be less than or equal to:
42 * ZS_MAX_ALLOC_SIZE - sizeof(struct zobj_header)
43 * otherwise, xv_malloc() would always return failure.
44 */
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-23 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 3:32 [PATCH 0/2] ZRAM Cleanup Marcos Paulo de Souza
2012-06-21 3:32 ` [PATCH 1/2] staging: zram: Remove some dead code Marcos Paulo de Souza
2012-06-21 3:32 ` [PATCH 2/2] staging: zram: Remove useless struct zobj_header Marcos Paulo de Souza
2012-06-23 15:18 ` Dan Carpenter [this message]
2012-06-21 5:02 ` [PATCH 0/2] ZRAM Cleanup Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623151819.GE5333@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm-cc@laptop.org \
--cc=marcos.souza.org@gmail.com \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox