From: Fengguang Wu <fengguang.wu@intel.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Paul Mundt <lethal@linux-sh.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON_ONCE
Date: Mon, 25 Jun 2012 12:38:36 +0800 [thread overview]
Message-ID: <20120625043836.GA11937@localhost> (raw)
In-Reply-To: <4FE7E7CA.2030706@xenotime.net>
On Sun, Jun 24, 2012 at 09:23:38PM -0700, Randy Dunlap wrote:
> On 06/24/2012 09:20 PM, Fengguang Wu wrote:
>
> > Hi Paul,
> >
> > The patch builds fine, thank you!
> >
> > Tested-by: Fengguang Wu <wfg@linux.intel.com>
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
>
> You clearly have better build hardware than I do (a simple Core i5
> laptop). ;)
Thanks, and it's a surprise that you caught so many bugs with a laptop! ;)
Thanks,
Fengguang
> >> I'm really starting to loathe this header. This should take care of it:
> >>
> >> ---
> >>
> >> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> >> index 506ec19..7d10f96 100644
> >> --- a/include/asm-generic/bug.h
> >> +++ b/include/asm-generic/bug.h
> >> @@ -3,10 +3,18 @@
> >>
> >> #include <linux/compiler.h>
> >>
> >> +#ifdef CONFIG_GENERIC_BUG
> >> +#define BUGFLAG_WARNING (1 << 0)
> >> +#define BUGFLAG_TAINT(taint) (BUGFLAG_WARNING | ((taint) << 8))
> >> +#define BUG_GET_TAINT(bug) ((bug)->flags >> 8)
> >> +#endif
> >> +
> >> +#ifndef __ASSEMBLY__
> >> +#include <linux/kernel.h>
> >> +
> >> #ifdef CONFIG_BUG
> >>
> >> #ifdef CONFIG_GENERIC_BUG
> >> -#ifndef __ASSEMBLY__
> >> struct bug_entry {
> >> #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
> >> unsigned long bug_addr;
> >> @@ -23,17 +31,8 @@ struct bug_entry {
> >> #endif
> >> unsigned short flags;
> >> };
> >> -#endif /* __ASSEMBLY__ */
> >> -
> >> -#define BUGFLAG_WARNING (1 << 0)
> >> -#define BUGFLAG_TAINT(taint) (BUGFLAG_WARNING | ((taint) << 8))
> >> -#define BUG_GET_TAINT(bug) ((bug)->flags >> 8)
> >> -
> >> #endif /* CONFIG_GENERIC_BUG */
> >>
> >> -#ifndef __ASSEMBLY__
> >> -#include <linux/kernel.h>
> >> -
> >> /*
> >> * Don't use BUG() or BUG_ON() unless there's really no way out; one
> >> * example might be detecting data structure corruption in the middle
>
>
>
> --
> ~Randy
next prev parent reply other threads:[~2012-06-25 4:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 4:33 linux-next: Tree for Jun 15 Stephen Rothwell
2012-06-15 6:52 ` error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON_ONCE Fengguang Wu
2012-06-15 16:27 ` Randy Dunlap
2012-06-18 16:54 ` Randy Dunlap
2012-06-22 7:13 ` Fengguang Wu
2012-06-25 2:53 ` Paul Mundt
2012-06-25 4:20 ` Fengguang Wu
2012-06-25 4:23 ` Randy Dunlap
2012-06-25 4:38 ` Fengguang Wu [this message]
2012-06-25 4:39 ` Randy Dunlap
2012-06-25 4:55 ` Fengguang Wu
2012-06-25 5:05 ` Randy Dunlap
2012-06-25 4:54 ` Paul Mundt
2012-06-15 19:19 ` [PATCH -next] pstore: fix printk format warning in ram.c Randy Dunlap
2012-06-15 19:32 ` Kees Cook
2012-06-22 0:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625043836.GA11937@localhost \
--to=fengguang.wu@intel.com \
--cc=arnd@arndb.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).