From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: 함명주 <myungjoo.ham@samsung.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
박경민 <kyungmin.park@samsung.com>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Extcon: Arizona: Add driver for Wolfson Arizona class devices
Date: Mon, 25 Jun 2012 09:51:52 +0100 [thread overview]
Message-ID: <20120625085151.GB4037@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <14300735.10471340599701741.JavaMail.weblogic@epv6ml01>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Mon, Jun 25, 2012 at 04:48:21AM +0000, 함명주 wrote:
> > + /* Microphone detection can't use idle mode */
> > + pm_runtime_get(info->dev);
> Is it alright to use asynchronous get here?
> (sync not required?)
Yes, it's OK to do this - we're guaranteed that the device is already
enabled at the time we decide to start the microphone detection (as
we're in the middle of examining the state which needs a runtime
reference). We're taking an additional reference here so that the
device doesn't get powered off again after the event has been handled.
> > + ret = arizona_request_irq(arizona, ARIZONA_IRQ_JD_RISE,
> > + "JACKDET rise", arizona_jackdet, info);
> Is this arizone_request_irq using threaded irq? (it's fine if so)
Yes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-25 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 4:48 [PATCH] Extcon: Arizona: Add driver for Wolfson Arizona class devices 함명주
2012-06-25 8:51 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 2:08 MyungJoo Ham
2012-06-28 10:17 ` Mark Brown
2012-06-24 11:09 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625085151.GB4037@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).