From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106Ab2FZAYL (ORCPT ); Mon, 25 Jun 2012 20:24:11 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:59605 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758083Ab2FZAYJ (ORCPT ); Mon, 25 Jun 2012 20:24:09 -0400 Date: Mon, 25 Jun 2012 17:24:05 -0700 From: "gregkh@linuxfoundation.org" To: H Hartley Sweeten Cc: Linux Kernel , "devel@driverdev.osuosl.org" , "fmhess@users.sourceforge.net" , "abbotti@mev.co.uk" Subject: Re: [PATCH 19/33] staging: comedi: cb_das16_cs: cleanup dio subdevice initialization Message-ID: <20120626002405.GA4497@kroah.com> References: <201206251700.20240.hartleys@visionengravers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2012 at 07:09:39PM -0500, H Hartley Sweeten wrote: > On Monday, June 25, 2012 5:00 PM, H Hartley Sweeten wrote: > > The digital i/o subdevice is always initialized due to the 'if (1)'. > > Simplify the attach by removing the test. > > > > Signed-off-by: H Hartley Sweeten > > Cc: Ian Abbott > > Cc: Frank Mori Hess > > Signed-off-by: Greg Kroah-Hartman > > Grr... Did it again. > > Sorry Greg. That should be a Cc not a Signed-off-by. Do you want > me to repost these? No problem, I'll edit it out.