public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Salman Qazi <sqazi@google.com>
To: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: [PATCH] sched: fix fork() error path to not crash.
Date: Mon, 25 Jun 2012 18:18:15 -0700	[thread overview]
Message-ID: <20120626011815.11323.5533.stgit@dungbeetle.mtv.corp.google.com> (raw)

In dup_task_struct, if arch_dup_task_struct fails, the clean up
code fails to clean up correctly.  That's because the clean up
code depends on unininitalized ti->task pointer.  We fix this
by making sure that the task and thread_info know about each other
before we attempt to take the error path.

Signed-off-by: Salman Qazi <sqazi@google.com>
---
 kernel/fork.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index ab5211b..f00e319 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -304,12 +304,17 @@ static struct task_struct *dup_task_struct(struct task_struct *orig)
 	}
 
 	err = arch_dup_task_struct(tsk, orig);
-	if (err)
-		goto out;
 
+	/*
+	 * We defer looking at err, because we will need this setup
+	 * for the clean up path to work correctly.
+	 */
 	tsk->stack = ti;
-
 	setup_thread_stack(tsk, orig);
+
+	if (err)
+		goto out;
+
 	clear_user_return_notifier(tsk);
 	clear_tsk_need_resched(tsk);
 	stackend = end_of_stack(tsk);


             reply	other threads:[~2012-06-26  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  1:18 Salman Qazi [this message]
2012-06-26  8:40 ` [PATCH] sched: fix fork() error path to not crash Peter Zijlstra
2012-06-26 16:58   ` Salman Qazi
2012-07-06  6:18 ` [tip:sched/core] sched: Fix " tip-bot for Salman Qazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626011815.11323.5533.stgit@dungbeetle.mtv.corp.google.com \
    --to=sqazi@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox