From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Chiwoong Byun <woong.byun@samsung.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: Re: [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ_DOMAIN
Date: Tue, 26 Jun 2012 10:53:32 +0200 [thread overview]
Message-ID: <20120626085332.GB4846@sortiz-mobl> (raw)
In-Reply-To: <1340674008.2942.1.camel@phoenix>
Hi Axel,
On Tue, Jun 26, 2012 at 09:26:48AM +0800, Axel Lin wrote:
> Select REGMAP_I2C to fix below build errors:
>
> CC drivers/mfd/max77686.o
> drivers/mfd/max77686.c:43:15: error: variable 'max77686_regmap_config' has initializer but incomplete type
> drivers/mfd/max77686.c:44:2: error: unknown field 'reg_bits' specified in initializer
> drivers/mfd/max77686.c:44:2: warning: excess elements in struct initializer [enabled by default]
> drivers/mfd/max77686.c:44:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
> drivers/mfd/max77686.c:45:2: error: unknown field 'val_bits' specified in initializer
> drivers/mfd/max77686.c:45:2: warning: excess elements in struct initializer [enabled by default]
> drivers/mfd/max77686.c:45:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
> drivers/mfd/max77686.c: In function 'max77686_i2c_probe':
> drivers/mfd/max77686.c:60:2: error: implicit declaration of function 'regmap_init_i2c' [-Werror=implicit-function-declaration]
> drivers/mfd/max77686.c:60:19: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/mfd/max77686.o] Error 1
> make[1]: *** [drivers/mfd] Error 2
> make: *** [drivers] Error 2
>
> Select IRQ_DOMAIN to fix below build errors:
I squashed this one with the initial commit, thanks a lot for the patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-06-26 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 1:26 [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ_DOMAIN Axel Lin
2012-06-26 8:53 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626085332.GB4846@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=woong.byun@samsung.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox