From: Oleg Nesterov <oleg@redhat.com>
To: Anton Arapov <anton@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] uprobes: __replace_page() needs munlock_vma_page()
Date: Tue, 26 Jun 2012 17:47:36 +0200 [thread overview]
Message-ID: <20120626154736.GA16141@redhat.com> (raw)
In-Reply-To: <20120626115514.GA16794@bandura.brq.redhat.com>
On 06/26, Anton Arapov wrote:
>
> On Sun, Jun 24, 2012 at 05:01:11PM +0200, Oleg Nesterov wrote:
> > Like do_wp_page(), __replace_page() should do munlock_vma_page()
> > for the case when the old page still has other !VM_LOCKED mappings.
> > Unfortunately this needs mm/internal.h.
> >
> > --- a/kernel/events/uprobes.c
> > +++ b/kernel/events/uprobes.c
> > @@ -32,6 +32,7 @@
> > #include <linux/swap.h> /* try_to_free_swap */
> > #include <linux/ptrace.h> /* user_enable_single_step */
> > #include <linux/kdebug.h> /* notifier mechanism */
> > +#include "../../mm/internal.h" /* munlock_vma_page */
>
> We have vma_adress() defined in internal.h, under #ifdef CONFIG_TRANSPARENT_HUGEPAGE .
>
> NAK. :-)
Damn you Anton ;) You seem to dislike number 5...
OK, please ignore this patch.
Can't resist. I swear, I specially checked mm/internal.h to ensure
it doesn't export mm/rmap.c:vma_address(), can't understand how I
didn't notice this declaration.
Oleg.
next prev parent reply other threads:[~2012-06-26 15:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 14:59 [PATCH v2 0/5] uprobes: write_opcode() cleanups Oleg Nesterov
2012-06-24 15:00 ` [PATCH v2 1/5] uprobes: don't recheck vma/f_mapping in write_opcode() Oleg Nesterov
2012-07-09 10:30 ` Srikar Dronamraju
2012-06-24 15:00 ` [PATCH v2 2/5] uprobes: __replace_page() should not use page_address_in_vma() Oleg Nesterov
2012-07-06 16:18 ` Oleg Nesterov
2012-07-09 10:28 ` Srikar Dronamraju
2012-06-24 15:00 ` [PATCH v2 3/5] uprobes: kill write_opcode()->lock_page(new_page) Oleg Nesterov
2012-07-09 10:29 ` Srikar Dronamraju
2012-06-24 15:00 ` [PATCH v2 4/5] uprobes: cleanup and document write_opcode()->lock_page(old_page) Oleg Nesterov
2012-07-09 10:29 ` Srikar Dronamraju
2012-06-24 15:01 ` [PATCH v2 5/5] uprobes: __replace_page() needs munlock_vma_page() Oleg Nesterov
2012-06-26 11:55 ` Anton Arapov
2012-06-26 15:47 ` Oleg Nesterov [this message]
2012-07-06 10:54 ` [PATCH v2 0/5] uprobes: write_opcode() cleanups Ingo Molnar
2012-07-06 16:07 ` Oleg Nesterov
2012-07-06 16:13 ` Oleg Nesterov
2012-07-09 9:12 ` Ingo Molnar
2012-07-09 13:30 ` Oleg Nesterov
2012-07-09 10:27 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626154736.GA16141@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).