From: Greg KH <gregkh@linuxfoundation.org>
To: Rupesh Gujare <rgujare@ozmodevices.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h
Date: Tue, 26 Jun 2012 15:07:32 -0700 [thread overview]
Message-ID: <20120626220732.GA21906@kroah.com> (raw)
In-Reply-To: <1340712221-6750-3-git-send-email-rgujare@ozmodevices.com>
On Tue, Jun 26, 2012 at 01:03:40PM +0100, Rupesh Gujare wrote:
> Fixes compilation error caused due to header file.
>
> Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
> ---
> drivers/staging/ozwpan/ozhcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
> index 251f07c..e3efa41 100644
> --- a/drivers/staging/ozwpan/ozhcd.c
> +++ b/drivers/staging/ozwpan/ozhcd.c
> @@ -28,7 +28,7 @@
> #include <linux/usb.h>
> #include <linux/jiffies.h>
> #include <linux/slab.h>
> -#include <linux/export.h>
> +#include <linux/module.h>
I don't understand, what is this fixing? It builds for me ok here, why
is module.h needed instead of export.h?
confused,
greg k-h
next prev parent reply other threads:[~2012-06-26 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 12:03 [PATCH 0/3] staging: ozwpan: Update TODO & fixes Rupesh Gujare
2012-06-26 12:03 ` [PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading Rupesh Gujare
2012-06-26 12:03 ` [PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h Rupesh Gujare
2012-06-26 22:07 ` Greg KH [this message]
2012-06-27 9:55 ` Rupesh Gujare
2012-06-26 12:03 ` [PATCH 3/3] staging: ozwpan: Update TODO file Rupesh Gujare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626220732.GA21906@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgujare@ozmodevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox