Re: [PATCH v2] Exynos : Add support for Exynos random number generator

[Jamie Iles <jamie@jamieiles.com>]

On Wed, Jun 27, 2012 at 08:21:50PM +0900, jonghwa3.lee@samsung.com wrote:
> On 2012년 06월 27일 20:07, Jamie Iles wrote:
> > On Wed, Jun 27, 2012 at 07:31:01PM +0900, Jonghwa Lee wrote:
> >> diff --git a/drivers/char/hw_random/Kconfig 
> >> b/drivers/char/hw_random/Kconfig
> >> index f45dad3..a9e3806 100644
> >> --- a/drivers/char/hw_random/Kconfig
> >> +++ b/drivers/char/hw_random/Kconfig
> >> @@ -263,3 +263,15 @@ config HW_RANDOM_PSERIES
> >>  	  module will be called pseries-rng.
> >>  
> >>  	  If unsure, say Y.
> >> +
> >> +config HW_RANDOM_EXYNOS
> >> +	tristate "EXYNOS HW random number generator support"
> >> +	depends on HW_RANDOM && ARCH_EXYNOS && HAS_IOMEM && PM_RUNTIME
> > 
> > I don't think this needs an ARCH_EXYNOS dependency does it?  I think you 
> > do need a dependency on HAVE_CLK though then it can be built for other 
> > platforms.
> > 
> This random number generator driver is only for Exynos SOC. And why
> should I add HAVE_CLK dependency since there is no relation with?

Well if you remove the ARCH_EXYNOS dependency then you should get higher 
build coverage which is a nice thing to have.

Anything using the clk API should have a dependency on HAVE_CLK as 
clk_*() doesn't have stubs for platforms that don't implement the API.

Jamie