From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] asm-generic: fix compile breakage "'TAINT_WARN' undeclared"
Date: Wed, 27 Jun 2012 23:22:34 +0900 [thread overview]
Message-ID: <20120627142233.GK24033@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1206271507200.24173@axis700.grange>
On Wed, Jun 27, 2012 at 03:52:27PM +0200, Guennadi Liakhovetski wrote:
> TAINT_WARN is defined in kernel.h and used in asm-generic/bug.h. Not
> including kernel.h there breaks build on sh:
>
> In file included from linux/include/linux/thread_info.h:54,
> from linux/include/linux/preempt.h:9,
> from linux/include/linux/spinlock.h:50,
> from linux/include/linux/mmzone.h:7,
> from linux/include/linux/gfp.h:4,
> from linux/include/linux/mm.h:8,
> from linux/arch/sh/kernel/asm-offsets.c:13:
> linux/arch/sh/include/asm/thread_info.h: In function 'set_restore_sigmask':
> linux/arch/sh/include/asm/thread_info.h:172: error: 'TAINT_WARN' undeclared (first use in this function)
> linux/arch/sh/include/asm/thread_info.h:172: error: (Each undeclared identifier is reported only once
> linux/arch/sh/include/asm/thread_info.h:172: error: for each function it appears in.)
>
> Also, since nothing in bug.h is usable from assembly, it is safe to extend
> the "#ifndef __ASSEMBLY__" block over all WARN() macros.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Already fixed in mainline.
prev parent reply other threads:[~2012-06-27 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 13:52 [PATCH] asm-generic: fix compile breakage "'TAINT_WARN' undeclared" Guennadi Liakhovetski
2012-06-27 14:22 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627142233.GK24033@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox