From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757378Ab2F0PLM (ORCPT ); Wed, 27 Jun 2012 11:11:12 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:53313 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850Ab2F0PLK (ORCPT ); Wed, 27 Jun 2012 11:11:10 -0400 Date: Wed, 27 Jun 2012 17:11:03 +0200 From: Frederic Weisbecker To: Jiri Olsa Cc: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org, cjashfor@linux.vnet.ibm.com, eranian@google.com, gorcunov@openvz.org, tzanussi@gmail.com, mhiramat@redhat.com, robert.richter@amd.com, fche@redhat.com, linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com, drepper@gmail.com, asharma@fb.com, benjamin.redelings@nescent.org Subject: Re: [PATCH 03/23] perf: Add ability to attach user level registers dump to sample Message-ID: <20120627151059.GG20638@somewhere.redhat.com> References: <1340120894-9465-1-git-send-email-jolsa@redhat.com> <1340120894-9465-4-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340120894-9465-4-git-send-email-jolsa@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2012 at 05:47:54PM +0200, Jiri Olsa wrote: > @@ -4061,6 +4105,19 @@ void perf_prepare_sample(struct perf_event_header *header, > } > header->size += size; > } > + > + if (sample_type & PERF_SAMPLE_REGS_USER) { > + /* regs dump available bool */ > + int size = sizeof(u64); > + > + data->regs_user = perf_sample_regs_user(regs); > + if (data->regs_user) { > + u64 mask = event->attr.sample_regs_user; > + size += hweight64(mask) * sizeof(u64); > + } > + > + header->size += size; We'll need to remove the 64 bits registers for compat tasks but other than that, it looks ok.