From: Tejun Heo <tj@kernel.org>
To: Glauber Costa <glommer@parallels.com>
Cc: Cgroups <cgroups@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: "Regression" with cd3d09527537
Date: Wed, 27 Jun 2012 16:08:23 -0700 [thread overview]
Message-ID: <20120627230823.GU15811@google.com> (raw)
In-Reply-To: <4FE9AE57.4090007@parallels.com>
On Tue, Jun 26, 2012 at 04:43:03PM +0400, Glauber Costa wrote:
> Hi,
>
> I've recently started seeing a lockdep warning at the end of *every*
> "init 0" issued in my machine. Actually, reboots are fine, and
> that's probably why I've never seen it earlier. The log is quite
> extensively, but shows the following dependency chain:
>
> [ 83.982111] -> #4 (cpu_hotplug.lock){+.+.+.}:
> [...]
> [ 83.982111] -> #3 (jump_label_mutex){+.+...}:
> [...]
> [ 83.982111] -> #2 (sk_lock-AF_INET){+.+.+.}:
> [...]
> [ 83.982111] -> #1 (&sig->cred_guard_mutex){+.+.+.}:
> [...]
> [ 83.982111] -> #0 (cgroup_mutex){+.+.+.}:
>
> I've recently fixed bugs with the lock ordering imposed by cpusets
> on cpu_hotplug.lock through jump_label_mutex, and initially thought
> it to be the same kind of issue. But that was not the case.
>
> I've omitted the full backtrace for readability, but I run this with
> all cgroups disabled but the cpuset, so it can't be sock memcg
> (after my initial reaction of "oh, fuck, not again"). That
> jump_label is there for years, and it comes from the code that
> disables socket timestamps.
> (net_enable_timestamp)
Yeah, there are multiple really large locks at play here - jump label,
threadgroup and cgroup_mutex. It isn't pretty. Can you please post
the full lockdep dump? The above only shows single locking chain.
I'd like to see the other.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-06-27 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 12:43 "Regression" with cd3d09527537 Glauber Costa
2012-06-27 23:08 ` Tejun Heo [this message]
2012-06-27 23:07 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627230823.GU15811@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).