From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755324Ab2F1NVF (ORCPT ); Thu, 28 Jun 2012 09:21:05 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:33359 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567Ab2F1NVD (ORCPT ); Thu, 28 Jun 2012 09:21:03 -0400 Date: Thu, 28 Jun 2012 08:20:58 -0500 From: Seth Forshee To: Arun Raghavan Cc: Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building Message-ID: <20120628132058.GA15308@thinkpad-t410> Mail-Followup-To: Arun Raghavan , Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1340879796-30262-1-git-send-email-arun.raghavan@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340879796-30262-1-git-send-email-arun.raghavan@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 28, 2012 at 04:06:36PM +0530, Arun Raghavan wrote: > apple_bl_register/unregister() are unconditionally used now, so we need > to make sure that apple_bl is selected appropriately (built-in/module) > if apple-gmux is being built. apple_bl.h provides stubs for these functions when apple_bl is not built, so this shouldn't be necessary. Are you encoutering a situation that causes build problems? Seth