From: Seth Forshee <seth.forshee@canonical.com>
To: Arun Raghavan <arun.raghavan@collabora.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building
Date: Thu, 28 Jun 2012 10:15:28 -0500 [thread overview]
Message-ID: <20120628151528.GD15308@thinkpad-t410> (raw)
In-Reply-To: <1340891471.4994.10.camel@localhost>
On Thu, Jun 28, 2012 at 07:21:11PM +0530, Arun Raghavan wrote:
> I missed the stubs, so the patch should probably just be adding this
> line:
>
> depends on APPLE_BACKLIGHT = n || APPLE_BACKLIGHT
>
> but that conflicts with the 'select BACKLIGHT_CLASS_DEVICE' (a recursive
> dependency is detected).
Sigh. We have a similar situation with acpi_video, which undoubtedly
also affects some other drivers as well.
This is the best I've been able to come up with.
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
depends on ACPI_VIDEO=n || ACPI_VIDEO
This at least keeps it from being built-in if it's going to be linking
against symbols provided by a module. I'm definitely open to other
suggestions though.
Seth
prev parent reply other threads:[~2012-06-28 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 10:36 [PATCH] apple-gmux: Correctly depend on apple_bl for building Arun Raghavan
2012-06-28 13:20 ` Seth Forshee
2012-06-28 13:23 ` Arun Raghavan
2012-06-28 13:48 ` Seth Forshee
2012-06-28 13:50 ` Seth Forshee
2012-06-28 13:51 ` Arun Raghavan
2012-06-28 15:15 ` Seth Forshee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628151528.GD15308@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=arun.raghavan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox