From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Feng Tang <feng.tang@intel.com>
Cc: David Ahern <dsahern@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Robert Richter <robert.richter@amd.com>,
Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 3/3] perf script/python: Pass event/thread/dso name and symbol info to event handler in python
Date: Thu, 28 Jun 2012 14:29:31 -0300 [thread overview]
Message-ID: <20120628172931.GA18586@infradead.org> (raw)
In-Reply-To: <20120628165027.43806b3d@feng-i7>
Em Thu, Jun 28, 2012 at 04:50:27PM +0800, Feng Tang escreveu:
> On Wed, 27 Jun 2012 15:58:17 -0300
> Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> > Now old scrips will break, as the tuple they expect:
> >
> > (attr, sample, raw_data)
> >
> > will not be there.
>
> Actually, there are no such scripts out. Current perf python script only
> supports the trace point type, while perl scriptt has the support for
> general events. It is my first patch "perf script: Add general python
> handler to process non-tracepoint events" which bring this (attr, sample,
> raw_data) in to be on the same page as perl. So this won't be a problem
> when the 3 patches are merged together.
Cool, I forgot about that, thanks for correcting me :-)
But even then, perf and python diverged in this... anyway, not a big
deal, I guess, the info available for perl scripts will be available in
the dict as well, right?
> > The first two patches in this series don't apply anymore, please find
> > them attached fixed, please check if they work as expected.
> Thanks a lot for fixing them, I'll generate perf tool patch against the
> "perf/core" branch of your git tree on kernel.org from now on.
>
> Btw, I have 2 more python scripts based on these patches, will add them
> to this serie for your review.
Ok, will take a look at them.
- Arnaldo
next prev parent reply other threads:[~2012-06-28 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 6:10 [PATCH v3 0/3] perf script: Add general event support to event handler of python script Feng Tang
2012-06-18 6:10 ` [PATCH v3 1/3] perf script: Add general python handler to process non-tracepoint events Feng Tang
2012-06-18 6:10 ` [PATCH v3 2/3] perf script: Replace "struct thread" with "struct addr_location" as a parameter for "process_event()" Feng Tang
2012-06-18 6:10 ` [PATCH v3 3/3] perf script/python: Pass event/thread/dso name and symbol info to event handler in python Feng Tang
2012-06-27 18:58 ` Arnaldo Carvalho de Melo
2012-06-28 8:50 ` Feng Tang
2012-06-28 17:29 ` Arnaldo Carvalho de Melo [this message]
2012-06-29 1:21 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628172931.GA18586@infradead.org \
--to=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox