From: "tj@kernel.org" <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: shyju pv <shyju.pv@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Sanil kumar <sanil.kumar@huawei.com>,
Masanari Iida <standby24x7@gmail.com>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]
Date: Thu, 28 Jun 2012 11:07:12 -0700 [thread overview]
Message-ID: <20120628180712.GC22641@google.com> (raw)
In-Reply-To: <4FEBF4B7.2070105@huawei.com>
Hello, Li.
On Thu, Jun 28, 2012 at 02:07:51PM +0800, Li Zefan wrote:
> > Hmm... fa980ca87d "cgroup: superblock can't be released with active
> > dentries" is supposed to have fixed that. Looking into it.
> >
>
>
> I think I know what happened here:
>
> umount
> deativate_super(sb)
> dput(subdir)
> subdir->d_count--
> d_release(subdir)
> deactivate_super(sb)
> shrink_dcache_for_umount(sb)
> BUG(root->d_count)!!
> root->d_count--
Can you please elaborate a bit? I'm not really following? Where does
the last root->d_count-- come from?
> I use this script to reproduce the bug:
>
> mount -t cgroup -o cpu xxx /mnt
> mkdir /mnt/sub
> sleep 100 < /mnt/sub &
> kill $!
> wait $!
> rmdir /mnt/sub
> umount /mnt
Unfortunately, this doesn't reproduce the bug here either. :(
Thanks.
--
tejun
next prev parent reply other threads:[~2012-06-28 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 19:08 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup] shyju pv
2012-06-26 23:00 ` Masanari Iida
2012-06-27 18:29 ` tj
2012-06-27 23:02 ` tj
2012-06-28 14:09 ` Masanari Iida
2012-06-28 6:07 ` Li Zefan
2012-06-28 6:07 ` Li Zefan
2012-06-28 18:07 ` tj [this message]
2012-06-29 2:20 ` Li Zefan
2012-06-29 16:58 ` tj
2012-06-29 18:07 ` Masanari Iida
2012-06-30 6:13 ` Li Zefan
2012-06-30 6:47 ` Al Viro
2012-06-30 7:04 ` Tejun Heo
2012-06-30 8:34 ` Al Viro
2012-07-03 17:10 ` Tejun Heo
2012-07-03 17:38 ` [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode Tejun Heo
2012-07-04 5:40 ` Li Zefan
2012-07-09 17:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628180712.GC22641@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=sanil.kumar@huawei.com \
--cc=shyju.pv@huawei.com \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).