public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [PATCH] backlight: add support for disabling backlights via sysfs
Date: Thu, 28 Jun 2012 20:10:43 +0100	[thread overview]
Message-ID: <20120628191043.GA9777@srcf.ucam.org> (raw)
In-Reply-To: <1340910426-13269-1-git-send-email-seth.forshee@canonical.com>

On Thu, Jun 28, 2012 at 02:07:06PM -0500, Seth Forshee wrote:

> Rather than trying to address this situation in a piecemeal fashion, we
> should find a solution that deal with disabling broken backlights more
> generically. This patch does so by adding an "enabled" attribute to
> sysfs for backlight devices. Writing 0 to this attribute disables the
> backlight, blocking most attempts to change the state. Tools like udev
> can set use this attribute to disable known broken backlight interfaces,
> and tools like gnome-settings-daemon can query the attribute to avoid
> using disabled backlights.

I'm not entirely thrilled by this, especially because in several cases I 
suspect that we're just going to end up disabling acpi_backlight rather 
than fixing any of the range of integration bugs we still have with it. 
If anyone has links with OEMs then I'd love to know how Windows handles 
backlight control policy, but otherwise I think Corentin's approach of 
having the vendor drivers promote or demote themselves makes more sense 
than pushing the problem out to userspace.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-06-28 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 19:07 [PATCH] backlight: add support for disabling backlights via sysfs Seth Forshee
2012-06-28 19:10 ` Matthew Garrett [this message]
2012-06-28 19:30   ` Seth Forshee
2012-06-28 19:36     ` Matthew Garrett
2012-06-28 21:16       ` Seth Forshee
2012-06-28 21:19         ` Matthew Garrett
2012-06-29  2:43           ` joeyli
2012-06-29  2:57             ` Matthew Garrett
2012-06-29  7:18               ` joeyli
2012-06-29 12:24       ` Corentin Chary
2012-06-29 14:11         ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628191043.GA9777@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=corentin.chary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox