From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [PATCH] backlight: add support for disabling backlights via sysfs
Date: Thu, 28 Jun 2012 20:36:52 +0100 [thread overview]
Message-ID: <20120628193652.GB10945@srcf.ucam.org> (raw)
In-Reply-To: <20120628193017.GA29456@thinkpad-t410>
On Thu, Jun 28, 2012 at 02:30:17PM -0500, Seth Forshee wrote:
> I actually don't think Corentin's solution is a bad one. It does suffer
> from a couple of shortcomings though. First, it only works for broken
> ACPI backlights, and some platforms have other backlight interfaces that
> are broken (e.g. the i915 backlight on the MacBook Pro 8,2). Second,
> marking backlights as broken in the kernel necessitates ever-expanding
> dmi blacklists in some of the platform drivers, unless we can get
> vendors to stop providing broken backlight interfaces.
Userspace should already be prioritising platform interfaces over raw
interfaces, so if gmux works on the Mac then there's no problem. DMI
lists should, broadly speaking, be unnecessary - they're mostly a
symptom of us not understanding how the hardware is expected to work.
> I'm all for fixing integration bugs in the ACPI backlight
> implementations if we can, but some vendor implementations are just
> flat-out broken, and it isn't always possible to get vendor cooperation.
> In the case of Toshiba I've tried reaching out to them to work on ACPI
> integration issues, but they flat out refused.
We already know that our implementation of the IGD opregion is broken,
but Intel won't hand over newer versions of the spec. If you see
problems with the acpi backlight interface on Intel graphics then that
should be the default assumption.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-06-28 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 19:07 [PATCH] backlight: add support for disabling backlights via sysfs Seth Forshee
2012-06-28 19:10 ` Matthew Garrett
2012-06-28 19:30 ` Seth Forshee
2012-06-28 19:36 ` Matthew Garrett [this message]
2012-06-28 21:16 ` Seth Forshee
2012-06-28 21:19 ` Matthew Garrett
2012-06-29 2:43 ` joeyli
2012-06-29 2:57 ` Matthew Garrett
2012-06-29 7:18 ` joeyli
2012-06-29 12:24 ` Corentin Chary
2012-06-29 14:11 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628193652.GB10945@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox