From: Ingo Molnar <mingo@kernel.org>
To: Shuah Khan <shuahkhan@gmail.com>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, joe@perches.com,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cleanups] x86/early_printk: Replace obsolete simple_strtoul() usage with kstrtoint()
Date: Fri, 29 Jun 2012 14:50:52 +0200 [thread overview]
Message-ID: <20120629125052.GC32637@gmail.com> (raw)
In-Reply-To: <1340644628.6882.3.camel@lorien2>
* Shuah Khan <shuahkhan@gmail.com> wrote:
> > I'm dropping this patch.
>
> No problem. I missed return value check in one path. Will fix
> it and send the fixed patch. I probably will pool this change
> with other simple_strtoul() cleanup related changes I am
> working on.
Yep, that will probably make it easier to review in a batch,
looking for side effects and such.
Thanks,
Ingo
next prev parent reply other threads:[~2012-06-29 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 16:48 [PATCH] x86: kernel/early_printk.c simple_strtoul cleanup Shuah Khan
2012-05-27 20:51 ` Joe Perches
2012-05-29 20:41 ` Shuah Khan
2012-05-31 0:40 ` [PATCH RESEND] " Shuah Khan
2012-06-06 15:15 ` [tip:x86/cleanups] x86/early_printk: Replace obsolete simple_strtoul() usage with kstrtoint() tip-bot for Shuah Khan
2012-06-22 14:24 ` Ingo Molnar
2012-06-25 17:17 ` Shuah Khan
2012-06-29 12:50 ` Ingo Molnar [this message]
2012-06-22 14:40 ` [tip:x86/cleanups] Revert "x86/early_printk: Replace obsolete simple_strtoul() usage with kstrtoint()" tip-bot for Ingo Molnar
2012-07-22 13:58 ` [tip:x86/platform] " tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629125052.GC32637@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=shuahkhan@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).