Re: [PATCH v3] printk: Have printk() never buffer its data

Greg Kroah-Hartman
2012-06-26T17:02:38Z

On Tue, Jun 26, 2012 at 07:00:38PM +0200, Kay Sievers wrote:
> On Tue, Jun 26, 2012 at 6:58 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Jun 26, 2012 at 06:07:36PM +0200, Kay Sievers wrote:
> >> On Mon, 2012-06-25 at 18:40 -0700, Linus Torvalds wrote:
> >> > On Mon, Jun 25, 2012 at 5:56 PM, Kay Sievers <kay@vrfy.org> wrote:
> >> > >
> >> > > Buffering has nice effects though:
> >> > > It makes continuation lines appear as one record in the buffer, not as
> >> > > n individual prints with n headers.
> >> >
> >> > As I already mentioned, buffering for *logging* is different from
> >> > buffering for *printing*.
> >> >
> >> > I think it might be a great idea to buffer for logging in order to
> >> > generate one individual buffer record there.
> >> >
> >> > But it needs to be printed as it is generated.
> >>
> >> That's a good idea.
> >>
> >> Something like this could work - only minimally tested at this moment.
> >
> > Hm, this doesn't boot for me, just hangs at startup :(
>
> You have that patch against your tree? Let me try that, maybe it
> conflicts with one of the patches there ...

No, I applied to to a clean 3.5-rc4 (which boots fine on my laptop).

greg k-h