From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Sangbeom Kim <sbkim73@samsung.com>
Cc: "'Liam Girdwood'" <lrg@ti.com>,
linux-kernel@vger.kernel.org, sbkim01@gmail.com
Subject: Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic
Date: Mon, 2 Jul 2012 16:33:43 +0200 [thread overview]
Message-ID: <20120702143343.GG22065@sortiz-mobl> (raw)
In-Reply-To: <20120618125232.GO3974@opensource.wolfsonmicro.com>
Hi Sangbeom,
On Mon, Jun 18, 2012 at 01:52:32PM +0100, Mark Brown wrote:
> On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote:
>
> > -struct sec_irq_data {
> > - int reg;
> > - int mask;
> > +static struct sec_irq_data s2mps11_irqs[] = {
> > + [S2MPS11_IRQ_PWRONF] = {
> > + .reg = 1,
> > + .mask = S2MPS11_IRQ_PWRONF_MASK,
> > + },
>
> This looks like you should be able to factor this code out into
> regmap_irq? Might be worth doing that first before all the renames so
> that adding the new PMIC would just be adding some more data.
Would you mind looking into that ? I'm ok with the renaming parts of this
patchset, but I think addressing Mark comment here would make the last patch
look better (and smaller).
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-07-02 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 11:29 [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic Sangbeom Kim
2012-06-18 12:52 ` Mark Brown
2012-07-02 14:33 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702143343.GG22065@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sbkim01@gmail.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox