From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rabin Vincent <rabin.vincent@stericsson.com>,
Sundar Iyer <sundar.iyer@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tc3589x: Guard PM methods with CONFIG_PM_SLEEP
Date: Mon, 2 Jul 2012 17:08:16 +0200 [thread overview]
Message-ID: <20120702150816.GN22065@sortiz-mobl> (raw)
In-Reply-To: <1341220792.10295.1.camel@phoenix>
Hi Axel,
On Mon, Jul 02, 2012 at 05:19:52PM +0800, Axel Lin wrote:
> Guard PM methods with CONFIG_PM_SLEEP and get rid of some unneeded #ifdefs.
> This fixes below build warnings:
>
> CC drivers/mfd/tc3589x.o
> drivers/mfd/tc3589x.c:361:12: warning: 'tc3589x_suspend' defined but not used [-Wunused-function]
> drivers/mfd/tc3589x.c:375:12: warning: 'tc3589x_resume' defined but not used [-Wunused-function]
>
> SIMPLE_DEV_PM_OPS already defines constant dev_pm_ops, thus also fix
> 'duplicate const' sparse warning.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/tc3589x.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-07-02 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 9:19 [PATCH] mfd: tc3589x: Guard PM methods with CONFIG_PM_SLEEP Axel Lin
2012-07-02 15:08 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702150816.GN22065@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox