From: Arnd Bergmann <arnd@arndb.de>
To: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: James.Bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linux-samsung-soc@vger.kernel.org,
santoshsy@gmail.com, arnd@linaro.org,
girish.shivananjappa@linaro.org, saugata.das@linaro.org,
vishak.g@samsung.com, venkat@linaro.org, k.rajesh@samsung.com,
yejin.moon@samsung.com, dsaxena@linaro.org,
ilho215.lee@samsung.com, nala.la@samsung.com,
stephen.doel@linaro.org, sreekumar.c@samsung.com
Subject: Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd
Date: Mon, 2 Jul 2012 15:20:03 +0000 [thread overview]
Message-ID: <201207021520.03774.arnd@arndb.de> (raw)
In-Reply-To: <1341239572-7408-4-git-send-email-vinholikatti@gmail.com>
On Monday 02 July 2012, Vinayak Holikatti wrote:
> +static struct amba_id ufshcd_amba_ids[] = {
> + {
> + /* Fake id for Primecell.*/
> + .id = 0x00041FF0,
> + .mask = 0x000fffff,
> + },
> + { 0, 0 },
> +};
Hi Vinayak,
Can you explain where this fake ID comes from? Is this ID actually
used by any hardware that is around somewhere? If not, I think it
would be better not to provide an AMBA driver at all, but instead
use the platform driver from patch 2 for all non-PCI uses.
Arnd
next prev parent reply other threads:[~2012-07-02 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 14:32 [PATCH 0/4] ufshcd: Adds glue drivers to ufshcd Vinayak Holikatti
2012-07-02 14:32 ` [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd Vinayak Holikatti
2012-07-02 15:17 ` Arnd Bergmann
2012-07-11 4:11 ` vinayak holikatti
2012-07-02 14:32 ` [PATCH 2/4] [SCSI] ufs: Add Platform " Vinayak Holikatti
2012-07-02 15:27 ` Arnd Bergmann
2012-07-11 4:14 ` vinayak holikatti
2012-07-02 14:32 ` [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd Vinayak Holikatti
2012-07-02 15:20 ` Arnd Bergmann [this message]
2012-07-11 4:20 ` vinayak holikatti
2012-07-02 14:32 ` [PATCH 4/4] [SCSI] ufs: Correct the expected data transfer size in UPIU Vinayak Holikatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207021520.03774.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@linaro.org \
--cc=dsaxena@linaro.org \
--cc=girish.shivananjappa@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=k.rajesh@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nala.la@samsung.com \
--cc=patches@linaro.org \
--cc=santoshsy@gmail.com \
--cc=saugata.das@linaro.org \
--cc=sreekumar.c@samsung.com \
--cc=stephen.doel@linaro.org \
--cc=venkat@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=vishak.g@samsung.com \
--cc=yejin.moon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox