public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: X86-ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH -v2 1/2] x86, microcode: Sanitize per-cpu microcode reloading interface
Date: Tue, 3 Jul 2012 12:41:35 +0200	[thread overview]
Message-ID: <20120703104135.GA12820@aftab.osrc.amd.com> (raw)
In-Reply-To: <1341307568.23484.54.camel@twins>

On Tue, Jul 03, 2012 at 11:26:08AM +0200, Peter Zijlstra wrote:
> On Tue, 2012-07-03 at 06:37 +0200, Borislav Petkov wrote:
> > In thinking about this a bit more, perf callback is only run from the
> > reload_store interface but we don't run it on module init time. 
> 
> @@ -557,7 +560,8 @@ static int __init microcode_init(void)
>         mutex_lock(&microcode_mutex);
> 
>         error = subsys_interface_register(&mc_cpu_interface);
> -
> +       if (!error)
> +               perf_check_microcode();
>         mutex_unlock(&microcode_mutex);
>         put_online_cpus();
> 
> 
> I thought that was init time?

Doh, I'm blind, sorry :-/

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

  reply	other threads:[~2012-07-03 10:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 12:07 [PATCH -v2 0/2] x86, microcode: Reload ucode only per-system Borislav Petkov
2012-06-21 12:07 ` [PATCH -v2 1/2] x86, microcode: Sanitize per-cpu microcode reloading interface Borislav Petkov
2012-06-21 12:12   ` Peter Zijlstra
2012-06-22 15:46   ` Peter Zijlstra
2012-06-26 19:40     ` Borislav Petkov
2012-06-26 19:51       ` Borislav Petkov
2012-06-26 21:46       ` Peter Zijlstra
2012-06-27  5:20         ` Borislav Petkov
2012-07-03  4:37         ` Borislav Petkov
2012-07-03  9:26           ` Peter Zijlstra
2012-07-03 10:41             ` Borislav Petkov [this message]
2012-07-01 19:35   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2012-06-21 12:07 ` [PATCH -v2 2/2] x86, microcode: Make reload interface per system Borislav Petkov
2012-06-21 12:12   ` Peter Zijlstra
2012-07-01 19:35   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2012-06-30 17:45 ` [PATCH -v2 0/2] x86, microcode: Reload ucode only per-system Borislav Petkov
2012-07-02  9:53   ` Peter Zijlstra
2012-07-02 13:05     ` H. Peter Anvin
2012-07-03 10:52       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120703104135.GA12820@aftab.osrc.amd.com \
    --to=bp@amd64.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=eranian@google.com \
    --cc=hmh@hmh.eng.br \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox