public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
	sameo@linux.intel.com
Subject: Re: [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration
Date: Tue, 3 Jul 2012 14:01:35 +0000	[thread overview]
Message-ID: <201207031401.36262.arnd@arndb.de> (raw)
In-Reply-To: <20120703132447.GN29030@opensource.wolfsonmicro.com>

On Tuesday 03 July 2012, Mark Brown wrote:
> > Before, when we probed each device from Device Tree we came up
> > against some fairly major limitations of the Device Tree. As a
> > result, Arnd and I agreed that this was the way to go.
> 
> I'm really unconvinced that instnatiating the MFD cells from device tree
> is in general a good idea.

In general it's not, e.g. it makes no sense when the MFD is just
a bunch of registers that are mapped to various distinct Linux
devices. The two mfd devices on ux500 (prcmu and ab8500) are really
buses by themselves that happen to be implemented using the MFD
framework on Linux.

I don't see how we would get around representing the buses in
the device tree because we have to refer to nodes under them
from off-chip devices. Simplified we have something like


  db9500 {
	prcmu {
		opp@1 {
		};

		regulator@2 {
		};

		watchdog@4 {
		};

		ab8500@5 {
			regulator@3 {
			};
			regulator@4 {
			};
			adc@a {
			};
			rtc@f {
			};
			irq@e {
			};
			gpio@10 {
			};
		};
	};
  };

Most of the stuff on the board is connected to the ab8500 regulators and
gpio pins, which are also used as interrupts. In order to hook up
the external devices in the device tree, we need to have something that
we can point to as their interrupt-parent or the phandle in the gpio
description.

	Arnd

  parent reply	other threads:[~2012-07-03 14:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 11:59 [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration Lee Jones
2012-07-03 12:35 ` Mark Brown
2012-07-03 13:07   ` Lee Jones
2012-07-03 13:24     ` Mark Brown
2012-07-03 13:48       ` Lee Jones
2012-07-03 14:21         ` Mark Brown
2012-07-05  7:36           ` Lee Jones
2012-07-05  9:45             ` Mark Brown
2012-07-05 11:46               ` Lee Jones
2012-07-05 12:06                 ` Mark Brown
2012-07-05 12:15                   ` Lee Jones
2012-07-05 12:29                     ` Mark Brown
2012-07-05 12:41                       ` Lee Jones
2012-07-05 12:45                         ` Mark Brown
2012-07-05 12:55                           ` Lee Jones
2012-07-05 13:03                             ` Mark Brown
2012-07-05 13:12                               ` Lee Jones
2012-07-05 13:20                                 ` Mark Brown
2012-07-05 13:54                                   ` Lee Jones
2012-07-05 13:57                                     ` Mark Brown
2012-07-05 14:06                                 ` Samuel Ortiz
2012-07-05 13:57                           ` Arnd Bergmann
2012-07-05 14:04                             ` Mark Brown
2012-07-05 14:06                             ` Lee Jones
2012-07-05 14:13                               ` Mark Brown
2012-07-05 14:35                                 ` Lee Jones
2012-07-05 15:41                                   ` Arnd Bergmann
2012-07-05 15:51                                     ` Lee Jones
2012-07-03 14:01       ` Arnd Bergmann [this message]
2012-07-03 14:43         ` Mark Brown
2012-07-05  7:33 ` Lee Jones
2012-07-05 13:08 ` Fabio Estevam
2012-07-05 13:13   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207031401.36262.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox