From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] regulator: don't fail to apply_uV for fixed regulators without set_voltage
Date: Tue, 3 Jul 2012 23:32:31 +0100 [thread overview]
Message-ID: <20120703223226.GA11368@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1341353014-13005-1-git-send-email-swarren@wwwdotorg.org>
On Tue, Jul 03, 2012 at 04:03:34PM -0600, Stephen Warren wrote:
> When instantiating a regulator from device tree,
> of_get_regulation_constraints() sets apply_uV=true when min_uV==max_uV.
> If the regulator only supports that one voltage, it may not implement
> set_voltage or set_voltage_sel. If so, the call from
> machine_constraints_voltage() to _regulator_do_set_voltage() will fail,
> since the latter requires one of those ops to be implemented. Avoid this
> problem by avoiding the call to _regulator_do_set_voltage() if the
> regulator is already set of the specified voltage.
This just seems like someone's written a silly device tree - they're
asking the OS to set a voltage on something with a fixed voltage. From
discussion on IRC it seems like this was a misunderstanding on your part
about what one is intended to put in the device tree, the idea is that
the DT should only specify things that are changed on the board - users
shouldn't need to cut'n'paste information that's fixed in the PMIC
silicon into each board DT.
Besides, there's clearly not anything specific to setting constraints
about this...
prev parent reply other threads:[~2012-07-03 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 22:03 [PATCH] regulator: don't fail to apply_uV for fixed regulators without set_voltage Stephen Warren
2012-07-03 22:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703223226.GA11368@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).