From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Fix recursive mutex lockdep warning
Date: Tue, 3 Jul 2012 23:43:16 +0100 [thread overview]
Message-ID: <20120703224316.GB11368@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF3514E.6050401@codeaurora.org>
On Tue, Jul 03, 2012 at 01:08:46PM -0700, Stephen Boyd wrote:
> On 07/03/12 12:26, Mark Brown wrote:
> > Applied, thanks. Though we should probably just remove the optimal mode
> > stuff on account of the total absence of any users...
> Please don't remove it. We use the optimal stuff fairly often
> internally, plus our usb driver is upstream and using the API.
>From what I remember there's a fair bit of non-upstream code you guys
have for regulators... your usage is certainly very unusual.
> What do you think about removing the locking in get_voltage? Is that better?
There's already an unlocked version of get_voltage()?
next prev parent reply other threads:[~2012-07-03 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 2:21 [PATCH] regulator: Fix recursive mutex lockdep warning Stephen Boyd
2012-07-03 19:26 ` Mark Brown
2012-07-03 20:08 ` Stephen Boyd
2012-07-03 22:43 ` Mark Brown [this message]
2012-07-03 22:47 ` Stephen Boyd
2012-07-03 23:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703224316.GB11368@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).