From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756809Ab2GDCjD (ORCPT ); Tue, 3 Jul 2012 22:39:03 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33330 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754426Ab2GDCjA (ORCPT ); Tue, 3 Jul 2012 22:39:00 -0400 Date: Wed, 4 Jul 2012 10:47:15 +0800 From: Zheng Liu To: Michael Tokarev Cc: Jeff Garzik , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Zheng Liu Subject: Re: [RFC][PATCH] libata: enable SATA disk fua detection on default Message-ID: <20120704024715.GA17095@gmail.com> Mail-Followup-To: Michael Tokarev , Jeff Garzik , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Zheng Liu References: <1336447443-4685-1-git-send-email-wenqing.lz@taobao.com> <20120703090441.GA4804@gmail.com> <4FF351F8.1000003@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FF351F8.1000003@msgid.tls.msk.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On Wed, Jul 04, 2012 at 12:11:36AM +0400, Michael Tokarev wrote: > On 03.07.2012 13:04, Zheng Liu wrote: > > Hi Jeff, > > > > Sorry for bothering you. Could you please review this patch, or give me > > some feedbacks. If this patch can be applied, I can rebase it to the > > lastest version of mainline kernel. Thank you. > [] > >> -int libata_fua = 0; > >> +int libata_fua = 1; > > I guess it can be enabled after LOTS of testing of various drives out > there, which shows that no current drives have issues with FUA anymore, > and after building a black-list of devices which misbehave. It is quite > a big project, I think. But what it gives us in return? > > (I've no idea if this is the right answer, speaking of myself only) Thanks for the reply. Indeed it is quite a big project but we enable FUA feature for SAS disk. Is there any differences? Regards, Zheng