From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937Ab2GDDog (ORCPT ); Tue, 3 Jul 2012 23:44:36 -0400 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:45931 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755336Ab2GDDof (ORCPT ); Tue, 3 Jul 2012 23:44:35 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dI1432Izz1202hzzz2dh2a8h668h839h944hd25hf0ah) Date: Wed, 4 Jul 2012 11:45:45 +0800 From: Zhao Chenhui To: Tabi Timur-B04825 CC: Zhao Chenhui-B35336 , "linuxppc-dev@lists.ozlabs.org" , Wood Scott-B07421 , "galak@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , Li Yang-R58472 , Subject: Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync Message-ID: <20120704034545.GA6196@localhost.localdomain> References: <1341310879-5468-1-git-send-email-chenhui.zhao@freescale.com> <20120704031426.GA6133@localhost.localdomain> <4FF3B5B6.8090400@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4FF3B5B6.8090400@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2012 at 10:17:12PM -0500, Tabi Timur-B04825 wrote: > Zhao Chenhui wrote: > > If the guts variable is NULL, it indicates there is error in dts or kernel. > > We should fix the error, rather than ignore it. > > And that's why there's a warning message. Crashing the kernel is not > going to fix anything. > This error likely crashes the kenel somewhere. > > Moreover, if smp_85xx_ops.give/take_timebase is NULL, kernel can not do the timebase sync. > > Is that necessary for the kernel to boot? > No. But in the cpu hotplug context, we need do the timebase sync. -Chenhui