RE: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking

Zhang, Sonic
2012-07-04T04:12:12Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1797 bytes --]

Acked-by: Sonic Zhang <sonic.zhang@analog.com>

>-----Original Message-----
>From: Axel Lin [mailto:axel.lin@gmail.com]
>Sent: Wednesday, July 04, 2012 11:55 AM
>To: Mark Brown
>Cc: linux-kernel@vger.kernel.org; Zhang, Sonic; Lars-Peter Clausen; Liam
>Girdwood
>Subject: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary
>checking
>
>It is ok to request current limit with min_uA < chip->min_uA and
>max_uA > chip->max_uA.
>
>We need to set min_uA = chip->min_uA if (min_uA < chip->min_uA),
>this ensures the equation to calcuate selator does not return negative number.
>
>Also set max_uA = chip->max_uA if (max_uA > chip->max_uA), as suggested by
>Sonic.
>
>Signed-off-by: Axel Lin <axel.lin@gmail.com>
>---
> drivers/regulator/ad5398.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
>index 46d05f3..f123f7e 100644
>--- a/drivers/regulator/ad5398.c
>+++ b/drivers/regulator/ad5398.c
>@@ -89,9 +89,12 @@ static int ad5398_set_current_limit(struct regulator_dev
>*rdev, int min_uA, int
> unsigned short data;
> int ret;
>
>- if (min_uA > chip->max_uA || min_uA < chip->min_uA)
>- return -EINVAL;
>- if (max_uA > chip->max_uA || max_uA < chip->min_uA)
>+ if (min_uA < chip->min_uA)
>+ min_uA = chip->min_uA;
>+ if (max_uA > chip->max_uA)
>+ max_uA = chip->max_uA;
>+
>+ if (min_uA > chip->max_uA || max_uA < chip->min_uA)
> return -EINVAL;
>
> selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level,
>--
>1.7.9.5
>
>
>

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥