* [PATCH] fcoe: unsigned long can never be negative
@ 2012-07-04 15:36 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-07-04 15:36 UTC (permalink / raw)
To: linux-kernel, akpm
From: Alan Cox <alan@linux.intel.com>
Coverity id: 703581
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/scsi/fcoe/fcoe_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c
index 2bc1631..5e75168 100644
--- a/drivers/scsi/fcoe/fcoe_sysfs.c
+++ b/drivers/scsi/fcoe/fcoe_sysfs.c
@@ -102,7 +102,7 @@ static int fcoe_str_to_dev_loss(const char *buf, unsigned long *val)
int ret;
ret = kstrtoul(buf, 0, val);
- if (ret || *val < 0)
+ if (ret)
return -EINVAL;
/*
* Check for overflow; dev_loss_tmo is u32
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-04 14:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-04 15:36 [PATCH] fcoe: unsigned long can never be negative Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox