From: Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen.de>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: [PATCH] crypto: twofish-avx - remove useless instruction
Date: Thu, 5 Jul 2012 20:43:58 +0200 [thread overview]
Message-ID: <20120705184358.GE2091@kronos.redsun> (raw)
The register %rdx is written, but never read till the end of the encryption
routine. Therefore let's delete the useless instruction.
Signed-off-by: Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen.de>
---
arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/crypto/twofish-avx-x86_64-asm_64.S b/arch/x86/crypto/twofish-avx-x86_64-asm_64.S
index fc31b89..35f4557 100644
--- a/arch/x86/crypto/twofish-avx-x86_64-asm_64.S
+++ b/arch/x86/crypto/twofish-avx-x86_64-asm_64.S
@@ -243,7 +243,6 @@ __twofish_enc_blk_8way:
popq %rbx;
leaq (4*4*4)(%rsi), %rax;
- leaq (4*4*4)(%rax), %rdx;
testb %cl, %cl;
jnz __enc_xor8;
--
1.7.2.5
next reply other threads:[~2012-07-05 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 18:43 Johannes Goetzfried [this message]
2012-07-05 23:46 ` [PATCH] crypto: twofish-avx - remove useless instruction Henrique de Moraes Holschuh
2012-07-06 0:13 ` Johannes Goetzfried
2012-07-11 3:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705184358.GE2091@kronos.redsun \
--to=johannes.goetzfried@informatik.stud.uni-erlangen.de \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox