Re: [PATCH 2/2] sunrpc/cache.h: replace simple_strtoul

Eldad Zack
2012-07-05T19:57:17Z

On Thu, 5 Jul 2012, J. Bruce Fields wrote:

> On Thu, Jul 05, 2012 at 09:04:03PM +0200, Eldad Zack wrote:
> >
> > On Wed, 4 Jul 2012, J. Bruce Fields wrote:
> > > On Thu, Jul 05, 2012 at 01:00:26AM +0200, Eldad Zack wrote:
> > > > This patch replaces the usage of simple_strtoul with kstrtoint in
> > > > get_int().
> > >
> > > Why?
> >
> > Since the simple_str* family don't account for overflow and AFAIK
> > deprecated. Also, in this specific case, the long from strtol is
> > silently converted to an int by the caller.
>
> OK, thanks. Please use that as the changelog when you resend. ("This
> patch replaces..." tells me nothing I couldn't figure out from looking
> at the patch.)

Will do, sorry about that.

Eldad