From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Nick Dyer <nick.dyer@itdev.co.uk>,
Yufeng Shen <miletus@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created
Date: Thu, 5 Jul 2012 21:15:39 +0200 [thread overview]
Message-ID: <20120705191539.GA14454@polaris.bitmath.org> (raw)
In-Reply-To: <20120705172230.GB31383@core.coreip.homeip.net>
On Thu, Jul 05, 2012 at 10:22:30AM -0700, Dmitry Torokhov wrote:
> Hi Daniel, Henrik,
>
> On Thu, Jun 28, 2012 at 09:08:05PM +0800, Daniel Kurtz wrote:
> > If sysfs entry creation fails, the driver is still usable, so don't
> > just abort probe. Just warn and continue.
> >
>
> I understand that I am a bit late to the party :) but I do not agree
> with this change. Failure to create attributes is not sometihng that
> user could cause (at least not easily) and thus would not be a setup
> issue but something more severe. I believe we should fail loading the
> driver so sysfs attribute breakage will be noticed as soon as possible,
> instead of discovering it much much later in the process.
>
> So I think we should revert this one.
Ok, I agree. Applied and pushed.
Daniel, I should probably have asked this before: what was the reason
for this patch in the first place?
Thanks,
Henrik
next prev parent reply other threads:[~2012-07-05 19:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 13:08 [PATCH 00/23 v6] cleanup atmel_mxt_ts Daniel Kurtz
2012-06-28 13:08 ` [PATCH 01/23 v6] Input: atmel_mxt_ts - derive phys from i2c client adapter Daniel Kurtz
2012-06-28 13:08 ` [PATCH 02/23 v6] Input: atmel_mxt_ts - use client name for irq Daniel Kurtz
2012-06-28 13:08 ` [PATCH 03/23 v6] Input: atmel_mxt_ts - detect OOM when creating mt slots Daniel Kurtz
2012-06-28 13:08 ` [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created Daniel Kurtz
2012-07-05 17:22 ` Dmitry Torokhov
2012-07-05 19:15 ` Henrik Rydberg [this message]
2012-07-16 2:34 ` Daniel Kurtz
2012-06-28 13:08 ` [PATCH 05/23 v6] Input: atmel_mxt_ts - don't read T5 when dumping objects Daniel Kurtz
2012-06-28 13:08 ` [PATCH 06/23 v6] Input: atmel_mxt_ts - use scnprintf for object sysfs entry Daniel Kurtz
2012-06-28 13:08 ` [PATCH 07/23 v6] Input: atmel_mxt_ts - optimize reading objects in " Daniel Kurtz
2012-06-28 13:08 ` [PATCH 08/23 v6] Input: atmel_mxt_ts - print less overhead when dumping objects Daniel Kurtz
2012-06-28 13:08 ` [PATCH 09/23 v6] Input: atmel_mxt_ts - print all instances " Daniel Kurtz
2012-06-28 13:08 ` [PATCH 10/23 v6] Input: atmel_mxt_ts - return errors from i2c layer Daniel Kurtz
2012-06-28 13:08 ` [PATCH 11/23 v6] Input: atmel_mxt_ts - add variable length __mxt_write_reg Daniel Kurtz
2012-06-28 13:08 ` [PATCH 12/23 v6] Input: atmel_mxt_ts - optimize writing of object table entries Daniel Kurtz
2012-06-28 13:08 ` [PATCH 13/23 v6] Input: atmel_mxt_ts - read ID information block in one i2c transaction Daniel Kurtz
2012-06-28 13:08 ` [PATCH 14/23 v6] Input: atmel_mxt_ts - update driver ID info logging Daniel Kurtz
2012-06-28 13:08 ` [PATCH 15/23 v6] Input: atmel_mxt_ts - add sysfs entries to read fw and hw version Daniel Kurtz
2012-06-28 13:08 ` [PATCH 16/23 v6] Input: atmel_mxt_ts - simplify event reporting Daniel Kurtz
2012-06-28 13:08 ` [PATCH 17/23 v6] Input: atmel_mxt_ts - add detail to touchevent debug message Daniel Kurtz
2012-06-28 13:08 ` [PATCH 18/23 v6] Input: atmel_mxt_ts - refactor when and how object table is freed Daniel Kurtz
2012-06-28 13:08 ` [PATCH 19/23 v6] Input: atmel_mxt_ts - cache T9 reportid range when reading object table Daniel Kurtz
2012-06-28 13:08 ` [PATCH 20/23 v6] Input: atmel_mxt_ts - refactor reportid checking in mxt_interrupt Daniel Kurtz
2012-06-28 13:08 ` [PATCH 21/23 v6] Input: atmel_mxt_ts - use T9 reportid range to init number of mt slots Daniel Kurtz
2012-06-28 13:08 ` [PATCH 22/23 v6] Input: atmel_mxt_ts - send all MT-B slots in one input report Daniel Kurtz
2012-06-28 13:08 ` [PATCH 23/23 v6] Input: atmel_mxt_ts - parse T6 reports Daniel Kurtz
2012-06-29 14:23 ` [PATCH 00/23 v6] cleanup atmel_mxt_ts Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705191539.GA14454@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox