From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166Ab2GFFYx (ORCPT ); Fri, 6 Jul 2012 01:24:53 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:53453 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329Ab2GFFYv (ORCPT ); Fri, 6 Jul 2012 01:24:51 -0400 Date: Fri, 6 Jul 2012 13:24:21 +0800 From: Wanpeng Li To: Gavin Shan Cc: Andrew Morton , Johannes Weiner , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcg: swappiness should between 0 and 100 Message-ID: <20120706052421.GC5929@kernel> Reply-To: Wanpeng Li References: <1341550312-6815-1-git-send-email-liwp.linux@gmail.com> <20120706051642.GA29829@shangw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120706051642.GA29829@shangw> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 01:16:43PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >>From: Wanpeng Li >> >>Signed-off-by: Wanpeng Li >>--- >> mm/memcontrol.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>index 5e4d1ab..69a7d45 100644 >>--- a/mm/memcontrol.c >>+++ b/mm/memcontrol.c >>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, >> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); >> struct mem_cgroup *parent; >> >>- if (val > 100) >>+ if (val > 100 || val < 0) > >Wanpeng, the "val" was defined as "u64". So how it could be less than 0? > >static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, > u64 val) > Oh, thank you! Just ignore this patch. Regards, Wanpeng Li >Thanks, >Gavin > >> return -EINVAL; >> >> if (cgrp->parent == NULL) >>-- >>1.7.5.4 >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: email@kvack.org >>