From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316Ab2GFJRB (ORCPT ); Fri, 6 Jul 2012 05:17:01 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:53503 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763Ab2GFJQ6 (ORCPT ); Fri, 6 Jul 2012 05:16:58 -0400 Date: Fri, 6 Jul 2012 10:29:47 +0200 From: Johannes Weiner To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/memcg: mem_cgroup_resize_xxx_limit can guarantee memcg->res.limit <= memcg->memsw.limit Message-ID: <20120706082947.GB1230@cmpxchg.org> References: <1341545055-5830-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341545055-5830-1-git-send-email-liwp.linux@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 11:24:15AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Changlog: > > V2: > * correct title Would it be possible to collect all these comment fixes you send out every other day into a single patch? > Signed-off-by: Wanpeng Li > --- > mm/memcontrol.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4b64fe0..a501660 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3418,7 +3418,7 @@ static int mem_cgroup_resize_limit(struct mem_cgroup *memcg, > /* > * Rather than hide all in some function, I do this in > * open coded manner. You see what this really does. > - * We have to guarantee memcg->res.limit < memcg->memsw.limit. > + * We have to guarantee memcg->res.limit <= memcg->memsw.limit. > */ It would probably make sense to also remove the first two sentences, they add nothing of value.