From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Vaibhav Nagarnaik <vnagarnaik@google.com>
Subject: Re: [PATCH 0/2] [GIT PULL][v3.5] ring-buffer: Fixes for the changes in the last merge window
Date: Fri, 6 Jul 2012 11:16:19 +0200 [thread overview]
Message-ID: <20120706091619.GE24449@gmail.com> (raw)
In-Reply-To: <20120629213545.533870841@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Ingo,
>
> This patch series has a couple of fixes for bugs that snuck
> into the last merge window. The first is a crash that can
> happen because of an uninitialized list, and failing to
> allocate the requested amount. This can happen by changing the
> buffer_size_kb to a huge amount as the first change that is
> done to it after booting up (note, the bug does not happen if
> a successful change happens first).
>
> The second patch can cause the ring buffer accounting (which
> is used by the infrastructure of the ring buffer) to get out
> of sync. This happens if you fill the buffer and then remove a
> few pages from it while it is full.
>
> The fixes are pretty simple, and should go into the 3.5-rc.
>
> Please pull the latest tip/perf/urgent tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> tip/perf/urgent
>
> Head SHA1: 48fdc72f23ad9a9956e524a47843135d0bbc3317
>
>
> Vaibhav Nagarnaik (2):
> ring-buffer: Fix crash due to uninitialized new_pages list head
> ring-buffer: Fix accounting of entries when removing pages
>
> ----
> kernel/trace/ring_buffer.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Pulled, thanks!
Ingo
prev parent reply other threads:[~2012-07-06 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 21:35 [PATCH 0/2] [GIT PULL][v3.5] ring-buffer: Fixes for the changes in the last merge window Steven Rostedt
2012-06-29 21:35 ` [PATCH 1/2] ring-buffer: Fix crash due to uninitialized new_pages list head Steven Rostedt
2012-06-29 21:35 ` [PATCH 2/2] ring-buffer: Fix accounting of entries when removing pages Steven Rostedt
2012-07-06 9:16 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706091619.GE24449@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox