From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933051Ab2GFKda (ORCPT ); Fri, 6 Jul 2012 06:33:30 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:53519 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932546Ab2GFKd3 (ORCPT ); Fri, 6 Jul 2012 06:33:29 -0400 Date: Fri, 6 Jul 2012 12:32:55 +0200 From: Johannes Weiner To: Peter Zijlstra Cc: Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Dan Smith , Bharata B Rao , Lee Schermerhorn , Andrea Arcangeli , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC][PATCH 02/26] mm, mpol: Remove NUMA_INTERLEAVE_HIT Message-ID: <20120706103255.GA23680@cmpxchg.org> References: <20120316144028.036474157@chello.nl> <20120316144240.234456258@chello.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120316144240.234456258@chello.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Fri, Mar 16, 2012 at 03:40:30PM +0100, Peter Zijlstra wrote: > Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants > to be compared to either a total of interleave allocations or to a miss > count, remove it. > > Fixing it would be possible, but since we've gone years without these > statistics I figure we can continue that way. > > This cleans up some of the weird MPOL_INTERLEAVE allocation exceptions. > > Signed-off-by: Peter Zijlstra > --- > @@ -111,7 +111,6 @@ enum zone_stat_item { > NUMA_HIT, /* allocated in intended node */ > NUMA_MISS, /* allocated in non intended node */ > NUMA_FOREIGN, /* was intended here, hit elsewhere */ > - NUMA_INTERLEAVE_HIT, /* interleaver preferred this zone */ > NUMA_LOCAL, /* allocation from local node */ > NUMA_OTHER, /* allocation from other node */ > #endif Can you guys include/fold this? --- From: Johannes Weiner Subject: [patch] mm: fix vmstat names-values off-by-one "mm/mpol: Remove NUMA_INTERLEAVE_HIT" removed the NUMA_INTERLEAVE_HIT item from the zone_stat_item enum, but left the corresponding name string for it in the vmstat_text array. As a result, all counters that follow it have their name offset by one from their value. Signed-off-by: Johannes Weiner --- mm/vmstat.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 1bbbbd9..e4db312 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -717,7 +717,6 @@ const char * const vmstat_text[] = { "numa_hit", "numa_miss", "numa_foreign", - "numa_interleave", "numa_local", "numa_other", #endif -- 1.7.7.6